-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18zh-cn: Upgrade & Migrate -> Upgrade from Tauri 1.0 #1644
Conversation
✅ Deploy Preview for tauri-v2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for this! @dklassic would you be able to help out with a review on this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
I find the translation to be pretty good, but besides on particular direct change suggestion, I'd like to ask you to do another sweep to improve the reading experience:
- Ensure a space is in between Chinese characters and half sized characters.
- Remove redundant space between two full sized characters (both Chinese characters and punctuations).
- Properly replace half sized punctuation with full sized Chinese punctuations, e.g. use ":" instead of ": ".
Also regarding inline translation of technical term coexisting with the original term, for example in the case of "迁移 Path 路径 至 Tauri Manager 管理器" the formatting is rather confusing to read. I would suggest to use brackets to the mark translated term, i.e. "迁移 Path(路径)至 Tauri Manager(管理器)"
Co-authored-by: DK Liao <[email protected]>
Addressed points brought up by @dklassic, polished some improvable translations and translated new content.
Seems I'm a bit late to the party, translations for this particular page has been completed by #1967. Closing. |
What kind of changes does this PR include?
Description