Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] Split tag validation error into two #889

Merged
merged 2 commits into from
Oct 28, 2024
Merged

[en] Split tag validation error into two #889

merged 2 commits into from
Oct 28, 2024

Conversation

kristian-clausal
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@xxyzz xxyzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small typo in the first message: f"invalid uppercase tag {tag} not in uppercase_tags".

The second message probably should only say it's not in valid_tags?

but kaikk.org's check JSON page doesn't combine similar messages because the full JSON string in the message, change the message probably still hard to find other non-tag messages.

@kristian-clausal
Copy link
Collaborator Author

Ah, I assumed this just passed the debug messages somewhere. The second message still checks uppercase_tags, so it should be correct.

@kristian-clausal
Copy link
Collaborator Author

By changing the called_from we can filter away the uppercase tag message because the kaikki.org page will only pull errors with the default called_from string. Didn't need to change anything on the kaikki side.

@xxyzz xxyzz merged commit 7675eda into master Oct 28, 2024
10 checks passed
@xxyzz
Copy link
Collaborator

xxyzz commented Oct 28, 2024

Thanks!

@kristian-clausal kristian-clausal deleted the invalid-tags branch October 28, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants