More other-edition field stuff #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristian-clausal
force-pushed
the
de-ipa
branch
from
dd90082 to
7c4fa7d
Compare
|
Apparently tests are still run in github actions even for drafts, so here's a --forced amended commit with tests. |
|
Spanish wiktionary has some template calls that we assume have args, but don't; basically, just So in this case the change is more appropriate on the kaikki.org side of things... EDIT: Actually, just don't add an empty etymology template to the data. |
For example "ipa" should not be a list inside a larger "sounds" list entry; if there are several "ipa" entries, make them separate "sounds" list entries, with their own tags etc. if necessary.
There's a lot of kludge here, so the next commit is probably just... going to nuke this completely. Committing this to keep the history, just in case there's something useful here.
Really, all the previous kludges in the previous commit are unnecessary if I'd just realized we only want to keep etymology template data for *etymology templates*, not just any template. So a simple substring check should suffice. It is unlikely that there are any conflicting templates with "etim" in their name, but possible.
kristian-clausal
force-pushed
the
de-ipa
branch
from
7c4fa7d to
372b117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I messed up my testing last time (by forgetting to use "--all" in wiktwords when generating the input json!!!!!), I need to do all the target language htmlgeneration attempts again, which will take a while but isn't complicated (now that I've figured out a procedure).