-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Containerfile #397
Add Containerfile #397
Conversation
The command of installing package from pypi.org is deleted because that package is so outdated. |
This seems good for those users who wish to use containers, I don't see why we couldn't have this. Is the image generation possible to automate so that upkeep of a GitHub package is hassle-free? |
Maybe just need to run two |
Thanks, this seems great. |
The published container image page in my fork repo: https://github.com/xxyzz/wiktextract/pkgs/container/wiktextract |
I always appreciate containerized applications when I just want to run an application as is. So this is a good addition. 👍 However, I don't think it solves all issues with versioning, in general. In the past, I have used wiktextract as a dependency and then overwritten or customized parts of the application and I always struggled with using a specific version of wiktextact. In particular, I used to fix the version of wiktextract by specifying a certain commit, e.g.: The problem is that the install script of As I understand, the containerized application won't have that problem. But in the described use case, where the wiktextract isn't run as is but used as a dependency, the container won't help. IMO, the ideal solution would be to introduce proper versioning for wiktextract's dependecies. |
You could use I don't think we could make releases for both packages, because Wiktionary changes every day and our parser is unstable. |
Run code in a container could solve all the environment errors. We could publish the container image to GitHub Packages so the users don't need to build the image. This could also relief the burden of compatible with older Python verisons.