Add config.json for German extractor #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work is a contribution to the EWOK project, which receives funding from LABEX ASLAN (ANR–10–LABX–0081) at the Université de Lyon, as part of the "Investissements d'Avenir" program initiated and overseen by the Agence Nationale de la Recherche (ANR) in France.
Fix tests tearDown This work is a contribution to the EWOK project, which receives funding from LABEX ASLAN (ANR–10–LABX–0081) at the Université de Lyon, as part of the "Investissements d'Avenir" program initiated and overseen by the Agence Nationale de la Recherche (ANR) in France.
- Catches and passes inflection-tables in the parse tree - Catches and passes the "Kategorie" links in the parse tree This work is a contribution to the EWOK project, which receives funding from LABEX ASLAN (ANR–10–LABX–0081) at the Université de Lyon, as part of the "Investissements d'Avenir" program initiated and overseen by the Agence Nationale de la Recherche (ANR) in France.
|
The "override" option was used for fixing broken templates and Lua modules, and for testing templates. The "overrides" folder must be moved inside the "src" folder to be included in the package, and the "wiktwords" command should apply the override JSON file automatically. I'll implement this feature in a pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary comment
I found my PRs were still too large recently. Going forward, I will try to keep each one focused on a small scope, even if that means having several open PRs in parallel.
Please let me know if you prefer it differently.
This PR
This PR is mainly to add a config.json and remove the hard-coded list of form-table templates for the German extractor.
See commit messages for the other minor additions.
Question
I wonder if I should also configure the German overrides to be used by default. Without them the whole extractor wouldn't work since the tree structure will be very different. Currently, the
--overrideflag is not clearly enough documented for the user to understand for which editions it's mandatory.