Extract French Wiktionary etymology list #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-expand them makes the list item nodes nested in HTML nodes, which is unnecessary.
|
At some points it would be good to go through all the differences that have accumulated between the en and fr/zh versions of the data 'scheme', so that we can consolidate them (probably change en closer to fr/zh, because en being older it doesn't meet all the needs of newer stuff and the newer stuff most probably is backwards compatible except when it isn't). |
|
This pr also adds a new "pos_title" in French JSON for matching etymology text. fr/zh uses "translation" in the "examples" list(it is "english" in English JSON). And Chinese JSON breaks Simplified/Transitional character example sentences to a list(also str in English JSON). That's some differences I can remember for now. |
Unlink English Wiktionary, French Wiktionary writes all etymology data
of different POS types inside the same section. And each POS data uses
a list("*") or indent(":").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extracts French Wiktionary etymology list and breaks the list text to JSON list "etymology_texts"(this is a str type for English JSON file), examples can be found in test cases.