Don't let section start token break unclosed parent node #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it shouldn't pop nodes in parser stack if it's inside an unclosed node like a template
kristian-clausal
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
If the test at the end seems to pass, the problem in the last post in the issue (about contenu3 being the child of the level 3 node?) seems to be fixed? Otherwise, all these changes seem correct. Sometimes there is no correct way to do things, and I suspect the way Wikitext works might be one of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it shouldn't pop nodes in parser stack if it's inside an unclosed node like a template
fixes #310