Fixing what looks to be a small bug

[neilcampbell]

The operation passed into Execute/ExecuteWithRetries seems to be invoked 1 additional time than the configured circuit breaker threshold before going into the open circuit state. I don't think this is the desired behavior.

This PR should fix it.
The tests will also log some info to the console to help give context.

[tathamoddie]

Howdy. Looks good at a glance. Hold up is that I need to get a proper build and release process going for this repo. (It’s pretty old.) Will try and get to that soon.

From: Neil Campbell [mailto:[email protected]]
Sent: Monday, 25 August 2014 23:45
To: tathamoddie/reliability-patterns
Subject: [reliability-patterns] Fixing what looks to be a small bug (#2)

The operation passed into Execute/ExecuteWithRetries seems to be invoked 1 additional time than the configured circuit breaker threshold before going into the open circuit state. I don't think this is the desired behavior.

This PR should fix it.
The tests will also log some info to the console to help give context.

---

You can merge this Pull Request by running

git pull https://github.com/neilcampbell/reliability-patterns master

Or view, comment on, or merge it at:

#2

Commit Summary

• Removing hgignore and adding gitignore
• Fixing what looks to be a bug, where the action is invoked 1 additional time than the configured circuit breaker threshold before going into the open circuit state.

File Changes

• A .gitignorehttps://github.com/Fixing what looks to be a small bug #2/files#diff-0 (17)
• D .hgignorehttps://github.com/Fixing what looks to be a small bug #2/files#diff-1 (6)
• M ReliabilityPatterns/CircuitBreaker.cshttps://github.com/Fixing what looks to be a small bug #2/files#diff-2 (7)
• A Tests/CircuitBreakerTestHelper.cshttps://github.com/Fixing what looks to be a small bug #2/files#diff-3 (61)
• M Tests/CircuitBreakerTests.cshttps://github.com/Fixing what looks to be a small bug #2/files#diff-4 (22)
• M Tests/RetryExtensionsTests.cshttps://github.com/Fixing what looks to be a small bug #2/files#diff-5 (14)
• M Tests/Tests.csprojhttps://github.com/Fixing what looks to be a small bug #2/files#diff-6 (1)

Patch Links:

• https://github.com/tathamoddie/reliability-patterns/pull/2.patch
• https://github.com/tathamoddie/reliability-patterns/pull/2.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2.

[neilcampbell]

No problems!

[neilcampbell]

@tathamoddie How are you going with the release stuff?

[neilcampbell]

@tathamoddie Any progress on this one?

[guibranco]

@tathamoddie any chance to merge this PR ?