Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support discovering pyc/pyd/so modules #391

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

keakon
Copy link

@keakon keakon commented Dec 18, 2024

I used Cython to compile the .py files into .so files. However, taskiq can only automatically discover .py files, so I added support for .pyc, .pyd, and .so files.

@s3rius
Copy link
Member

s3rius commented Dec 18, 2024

Can you rebase onto last commit from master branch?

I have updated a workflow, so tests should run after the update.

@keakon
Copy link
Author

keakon commented Dec 19, 2024

Sure, can you run the tests now?

s3rius
s3rius previously approved these changes Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.40%. Comparing base (ff6dc26) to head (efb3488).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
- Coverage   77.51%   77.40%   -0.11%     
==========================================
  Files          62       62              
  Lines        1899     1899              
==========================================
- Hits         1472     1470       -2     
- Misses        427      429       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s3rius
Copy link
Member

s3rius commented Dec 21, 2024

Run pre-commit run -a before pushing.

@keakon
Copy link
Author

keakon commented Dec 25, 2024

Run pre-commit run -a before pushing.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants