Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set uvloop for current thread explicitly. #270

Merged

Conversation

ivaaahn
Copy link
Contributor

@ivaaahn ivaaahn commented Dec 28, 2023

Should help fix a similar problem to #229, but in the case of using uvloop.

I caught this problem on python3.8 with uvloop.

@ivaaahn ivaaahn force-pushed the bugfix/explicit-uvloop-setting branch from dcbd042 to 69b65e0 Compare December 28, 2023 22:17
Copy link
Member

@s3rius s3rius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for contribution.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.31%. Comparing base (7030a54) to head (69b65e0).
Report is 44 commits behind head on develop.

Files Patch % Lines
taskiq/cli/worker/run.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #270   +/-   ##
========================================
  Coverage    77.31%   77.31%           
========================================
  Files           60       60           
  Lines         1750     1750           
========================================
  Hits          1353     1353           
  Misses         397      397           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s3rius s3rius merged commit d8237b8 into taskiq-python:develop Dec 30, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants