Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed source from the TaskiqSchedule. #218

Merged
merged 4 commits into from
Oct 15, 2023
Merged

Conversation

s3rius
Copy link
Member

@s3rius s3rius commented Oct 15, 2023

The source field in the TaskiqSchedule class seemed to be redundant for me. It was adding unnecessary complexity for the extensions API. This change is incompatible with the previous version.

Signed-off-by: Pavel Kirilin [email protected]

Signed-off-by: Pavel Kirilin <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

Merging #218 (12bfbb0) into develop (e66f3aa) will increase coverage by 6.02%.
Report is 137 commits behind head on develop.
The diff coverage is 74.01%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #218      +/-   ##
===========================================
+ Coverage    67.62%   73.64%   +6.02%     
===========================================
  Files           37       55      +18     
  Lines          942     1624     +682     
===========================================
+ Hits           637     1196     +559     
- Misses         305      428     +123     
Files Coverage Δ
taskiq/__init__.py 100.00% <100.00%> (ø)
taskiq/abc/formatter.py 100.00% <100.00%> (ø)
taskiq/abc/middleware.py 100.00% <ø> (ø)
taskiq/abc/result_backend.py 100.00% <ø> (ø)
taskiq/abc/serializer.py 100.00% <100.00%> (ø)
taskiq/acks.py 100.00% <100.00%> (ø)
taskiq/api/__init__.py 100.00% <100.00%> (ø)
taskiq/cli/common_args.py 100.00% <100.00%> (ø)
taskiq/cli/watcher.py 0.00% <ø> (ø)
taskiq/cli/worker/log_collector.py 100.00% <ø> (ø)
... and 42 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Pavel Kirilin <[email protected]>
Signed-off-by: Pavel Kirilin <[email protected]>
@s3rius s3rius merged commit 02c2817 into develop Oct 15, 2023
11 checks passed
@s3rius s3rius deleted the feature/no-schedule-sources branch October 15, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants