Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog #59

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Changelog #59

merged 3 commits into from
Jun 8, 2022

Conversation

Julow
Copy link
Member

@Julow Julow commented Jun 7, 2022

We should keep a changelog!

I propose we force ourselves to think about the changelog at every PRs. I've hooked https://github.com/tarides/changelog-check-action into the CI to check that. It'll fail if the changelog hasn't been updated, this can be disabled with the no changelog tag.

I've left out PRs modifying only the README (#51, #45, #49 and this one) in the initial changelog.

@pitag-ha
Copy link
Member

pitag-ha commented Jun 7, 2022

Perfect, thanks!

I've hooked https://github.com/tarides/changelog-check-action into the CI to check that.

Cool! What do you think about using @Leonidas-from-XIV's version of that? Apart from checking if the changelog has been changed, it also replaces #<PR_NUMBER> with the number of the PR. We could just copy the configuration we have for that in dune-release

@pitag-ha
Copy link
Member

pitag-ha commented Jun 7, 2022

Btw, do you know why the CI is failing?

@Leonidas-from-XIV
Copy link
Member

Glad to see that others find value in the actions! There's actually two of them:

  1. The check changelog action that makes sure a changelog is updated in the PR
  2. the pr-number-action that suggests the PR number exactly as @pitag-ha describes

@Julow
Copy link
Member Author

Julow commented Jun 8, 2022

I've added the pr-number too, this looks very useful.
The job that is failing in CI is one that shouldn't run. (fixed in https://github.com/tarides/ocaml-platform/pull/56)

@Julow Julow merged commit 78b3646 into tarides:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants