Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: staged security dialog fix #1040

Merged
merged 3 commits into from
Feb 6, 2024
Merged

feat: staged security dialog fix #1040

merged 3 commits into from
Feb 6, 2024

Conversation

igordanilcenko
Copy link
Contributor

Fix the multiple staged wallet security dialog bug

  • Fix the wrong date comparison
  • Fix the memory leak when StagedWalletSecurityManager held an instance of a balance check event subscription even when the app stops
  • Make StagedWalletSecurityManager a singleton and move all display logic to the VM
  • Got rid of the balanceUpdates event bus event
  • Added a couple of useful utils
  • Cleaned up the code

@igordanilcenko igordanilcenko self-assigned this Feb 6, 2024
@igordanilcenko igordanilcenko merged commit fbe1286 into development Feb 6, 2024
1 check passed
@igordanilcenko igordanilcenko deleted the feature/staged_security_dialog_fix branch February 6, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TruszczynskiA TruszczynskiA TruszczynskiA approved these changes

Assignees

@igordanilcenko igordanilcenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igordanilcenko @TruszczynskiA @ghpbot-tari-project