Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor backup related code #1038

Merged

Conversation

igordanilcenko
Copy link
Contributor

The first iteration of the fix of the Backup feature.
I prepared code for further refactoring and bug fixing:

  • Moved domain logic out from views to viewModels
  • Made classes more stateless by passing required inputs as arguments instead of storing them in third-party classes

And also made some enhancements:

  • Added some useful extension functions
  • Renamed some classes and variables meaningfully (e.g. BackupOptions -> BackupOptionType because it is an enum with possible option types)
  • Made log messages more informative
  • Made some nullable values null-safe
  • Moved view state variables to separate immutable UiState classes

Notes:

  • I left some TODOs required for continuation of my work

@igordanilcenko igordanilcenko self-assigned this Jan 31, 2024
@igordanilcenko igordanilcenko changed the title Refactor backup related code feat: refactor backup related code Jan 31, 2024
@igordanilcenko igordanilcenko merged commit f72e831 into feature/backup-options-fix Feb 5, 2024
1 of 2 checks passed
@igordanilcenko igordanilcenko deleted the feature/refactor-backup-code branch February 5, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants