Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(restart): optional stopping miners for restart application #1060

Conversation

mmrrnn
Copy link
Collaborator

@mmrrnn mmrrnn commented Nov 12, 2024

Added a flag for terminating processes before restarting the app. We don't want to kill processes during auto-updates, but in other cases we want to kill them and prevent from hanging processes and killing them after the restart.

@brianp
Copy link
Collaborator

brianp commented Nov 14, 2024

Why don't we want to kill processes during auto-update? What if the miner applications had been updated?

@mmrrnn
Copy link
Collaborator Author

mmrrnn commented Nov 14, 2024

App is stopped until user decides whether he wants to update the app or not - in that case we would freeze the app trying to kill miners that hasn't even started yet

@brianp brianp merged commit 57ac88e into tari-project:main Nov 14, 2024
9 checks passed
@Tas4tari
Copy link

Tested on Windows 11, app version 0.6.15. I find that when I click on Restart Now nothing occurs for a few seconds and gives me the impression that the CTA is not working before the app eventually closes. As a user this experience is not ideal for me as I almost closed the app manually thinking that perhaps it may have frozen etc

@Anziskavds
Copy link

Tested on MacBook Air 13 inch M1 2020 and I also experience the delay when clicking on the Restart now button. I've experienced this on Testnet v0.6.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants