Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update pre-mine specification and allow multiple spends #6590

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

hansieodendaal
Copy link
Contributor

Description

  • Updated the pre-mine specification to cater for different upfront release strategies.
  • Update pre-mine spending to take into account spending multiples of multiple outputs to a single wallet.

Motivation and Context

Catering for new requirements.

How Has This Been Tested?

System-level testing [TBD]

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal hansieodendaal requested a review from a team as a code owner September 30, 2024 15:56
@hansieodendaal hansieodendaal marked this pull request as draft September 30, 2024 15:57
@hansieodendaal hansieodendaal changed the title feat: update the pre-mine specification and allow multiple pre-mine output spends to a single wallet feat: update the pre-mine specification and allow multiple spends Sep 30, 2024
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 30, 2024
@hansieodendaal hansieodendaal changed the title feat: update the pre-mine specification and allow multiple spends feat: update pre-mine specification and allow multiple spends Sep 30, 2024
Copy link

github-actions bot commented Sep 30, 2024

Test Results (CI)

    3 files    129 suites   35m 13s ⏱️
1 324 tests 1 324 ✅ 0 💤 0 ❌
3 970 runs  3 970 ✅ 0 💤 0 ❌

Results for commit 6f0ff68.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 30, 2024

Test Results (Integration tests)

 2 files  11 suites   40m 36s ⏱️
36 tests 35 ✅ 0 💤 1 ❌
38 runs  35 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 6f0ff68.

♻️ This comment has been updated with latest results.

- Updated the pre-mine specification to cater for different upfront release strategies
- Updated pre-mine spend to take into account spending multiple outputs to a single
  wallet
- Updated pre-mine spend to output immediate genesis block spends to json for inclusion
  in the genesis block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants