-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(indexer): quorum certificate validation #893
base: development
Are you sure you want to change the base?
Conversation
Test Results (CI)80 tests - 367 79 ✅ - 368 59m 36s ⏱️ - 1h 51m 7s For more details on these failures, see this check. Results for commit 6f5dca6. ± Comparison against base commit b526c09. This pull request removes 367 tests.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Description
GetSubstateResponse
type.consensus
crate, and reuse it for block validations inside the VN as well as in the indexer.TariSignatureService
totari_dan_app_utilities
, so it can be reused from VNs and indexers.Motivation and Context
Right now indexers and wallets trust the substate values received from VNs. Ideally we would want this process to be totally trustless by validating a QC sent by the VN alongside the substate value.
But right now this is not possible as the QC does not include the appropriate information for validating the substate value. Anyway, the goal of this PR to implement the boilerplate needed as the first step towards trustless VNs:
How Has This Been Tested?
Related integration tests pass
What process can a PR reviewer use to test or verify this change?
Not applicable
Breaking Changes