refactor(consensus)!: split block header and body #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)582 tests +25 581 ✅ +24 3h 14m 56s ⏱️ + 1h 48m 47s For more details on these failures, see this check. Results for commit fa1abf0. ± Comparison against base commit 4df7ec7. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor(consensus)!: split block header and body
feat: add command Merkle root to header
Updated validator node web UI
Motivation and Context
This PR allows for shorter command inclusion proofs by not requiring the entire block contents to be part of the proof.
A proof (not implemented) would contain the block header, a Merkle proof and the justify QC chain.
How Has This Been Tested?
Existing tests and manually
What process can a PR reviewer use to test or verify this change?
Internal changes, nothing has changed on the DB level
Breaking Changes
BREAKING CHANGE: protobuf changes that are not compatible with previous versions. Blocks in database include a
command_merkle_root