fix(consensus): vote handling improvement, bug fixes #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
consensus-count-attestations
branch
from
acdfd8f
to
2a8caec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(consensus): vote handling improvement, bug fixes
Set preshards to 256
Fix sending duplicate transaction gossips
Wait for foreign proposal before sequencing an output-only transaction that only currently involves the transaction receipt substate
Motivation and Context
Removed unnecessary view change calls when receiving votes from newviews
Removed several epoch manager calls that can use committee info
Fixed bug in vote processing
Set number of preshards to 256 to test that it works (which it does so I've kept it)
Add checks for valid block ids to a number of pending data database calls
Fix propose bug where incorrect state could be used when parent block if a dummy