Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus)!: fix block and leader fee proposals #1133

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Sep 4, 2024

Description

Fixes leader and block fee proposals

Motivation and Context

total_leader_fee was always 0 in blocks.

How Has This Been Tested?

Manually

What process can a PR reviewer use to test or verify this change?

Check the total_leader fee > 0 in blocks with LocalOnly/AllAccept

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

github-actions bot commented Sep 4, 2024

Test Results (CI)

553 tests  ±0   553 ✅ ±0   2h 2m 34s ⏱️ + 1m 48s
 58 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit bbc8600. ± Comparison against base commit d6bae3b.

♻️ This comment has been updated with latest results.

@sdbondi sdbondi merged commit 0ca3504 into tari-project:development Sep 5, 2024
12 checks passed
@sdbondi sdbondi deleted the consensus-fix-block-leader-fee branch September 5, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants