Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(watcher): general fixes while testing #1131

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix(watcher): general fixes while testing #1131

merged 2 commits into from
Sep 4, 2024

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Sep 3, 2024 •
edited
Loading

Description

Some teething fixes for watcher
Conseistently use URL format for minotari node GRPC address

How Has This Been Tested?

Manually

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

Test Results (CI)

553 tests  +445   553 ✅ +446   1h 38m 34s ⏱️ + 1h 6m 7s
 58 suites + 43     0 💤 ±  0 
  2 files   +  1     0 ❌  -   1 

Results for commit 0e6f37b. ± Comparison against base commit 9b6b704.

♻️ This comment has been updated with latest results.

@sdbondi sdbondi force-pushed the watcher-fixes branch 2 times, most recently from a5fae62 to 71a039d Compare September 4, 2024 05:55
@sdbondi sdbondi marked this pull request as ready for review September 4, 2024 05:55
@sdbondi sdbondi force-pushed the watcher-fixes branch 2 times, most recently from 0f18fee to ba49862 Compare September 4, 2024 06:51
therealdannzor
therealdannzor approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@therealdannzor therealdannzor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great fixes across crates :)

@sdbondi sdbondi added this pull request to the merge queue Sep 4, 2024
Merged via the queue into tari-project:development with commit d6bae3b Sep 4, 2024
12 checks passed
@sdbondi sdbondi deleted the watcher-fixes branch September 4, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealdannzor therealdannzor therealdannzor approved these changes

Assignees
No one assigned
Labels
P-acks_required P-reviews_required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdbondi @therealdannzor @ghpbot-tari-project