Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dan)!: update nft address format #1129

Merged

Conversation

therealdannzor
Copy link
Contributor

Description

Resolves #1080

Motivation and Context

Updates the format of the NFT address by removing the blank space between the resource and nft components

Breaking Changes

NFT address format updated

  • None
  • Requires data directory to be deleted
  • Other - Please specify

dan_layer/engine_types/src/substate.rs Outdated Show resolved Hide resolved
dan_layer/engine_types/src/substate.rs Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 3, 2024

Test Results (CI)

173 tests   - 380   164 ✅  - 389   3h 56m 0s ⏱️ + 1h 59m 24s
 23 suites  -  35     0 💤 ±  0 
  1 files    -   1     9 ❌ +  9 

For more details on these failures, see this check.

Results for commit d7c253d. ± Comparison against base commit 0ca3504.

This pull request removes 380 tests.
Scenario: Claim and transfer confidential assets via wallet daemon: tests/features/wallet_daemon.feature:90:3
Scenario: Claim base layer burn funds with wallet daemon: tests/features/claim_burn.feature:7:3
Scenario: Confidential transfer to unexisting account: tests/features/transfer.feature:164:3
Scenario: Create account and transfer faucets via wallet daemon: tests/features/wallet_daemon.feature:8:3
Scenario: Create and mint account NFT: tests/features/wallet_daemon.feature:134:3
Scenario: Double Claim base layer burn funds with wallet daemon. should fail: tests/features/claim_burn.feature:45:3
Scenario: New validator node registers and syncs: tests/features/state_sync.feature:7:3
Scenario: Template registration and invocation in a 2-VN committee: tests/features/committee.feature:7:3
Scenario: Transfer tokens to existing account: tests/features/transfer.feature:87:3
Scenario: Transfer tokens to unexisting account: tests/features/transfer.feature:8:3
…

♻️ This comment has been updated with latest results.

dan_layer/engine_types/src/substate.rs Outdated Show resolved Hide resolved
dan_layer/engine_types/src/substate.rs Outdated Show resolved Hide resolved
dan_layer/engine_types/src/substate.rs Outdated Show resolved Hide resolved
dan_layer/engine_types/src/substate.rs Outdated Show resolved Hide resolved
dan_layer/template_lib/src/models/non_fungible.rs Outdated Show resolved Hide resolved
dan_layer/template_lib/src/models/non_fungible.rs Outdated Show resolved Hide resolved
sdbondi
sdbondi previously approved these changes Sep 5, 2024
@sdbondi sdbondi added this pull request to the merge queue Sep 5, 2024
Merged via the queue into tari-project:development with commit 2b5ba47 Sep 5, 2024
11 of 12 checks passed
@therealdannzor therealdannzor deleted the fix-improve-nft-address-format branch September 5, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve NFT address strings
3 participants