-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dan)!: update nft address format #1129
Merged
sdbondi
merged 22 commits into
tari-project:development
from
therealdannzor:fix-improve-nft-address-format
Sep 5, 2024
Merged
fix(dan)!: update nft address format #1129
sdbondi
merged 22 commits into
tari-project:development
from
therealdannzor:fix-improve-nft-address-format
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
reviewed
Sep 3, 2024
Test Results (CI)173 tests - 380 164 ✅ - 389 3h 56m 0s ⏱️ + 1h 59m 24s For more details on these failures, see this check. Results for commit d7c253d. ± Comparison against base commit 0ca3504. This pull request removes 380 tests.
♻️ This comment has been updated with latest results. |
…nnzor/tari-dan into fix-improve-nft-address-format
sdbondi
reviewed
Sep 4, 2024
sdbondi
reviewed
Sep 4, 2024
therealdannzor
force-pushed
the
fix-improve-nft-address-format
branch
from
September 4, 2024 14:00
3aa9e2e
to
8dbaee2
Compare
sdbondi
previously approved these changes
Sep 5, 2024
sdbondi
approved these changes
Sep 5, 2024
Merged
via the queue into
tari-project:development
with commit Sep 5, 2024
2b5ba47
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1080
Motivation and Context
Updates the format of the NFT address by removing the blank space between the
resource
andnft
componentsBreaking Changes
NFT address format updated