feat(swarm): list all running instances (ports etc) #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* development: feat(consensus): proposed block parked and ready event (tari-project#1055) fix(swarm): reuse allocated ports after restart (tari-project#1056) fix(indexer): reuse validator RPC sessions (tari-project#1057) fix(indexer): clippy fixes (tari-project#1052)
* development: feat(swarm): json-rpc call to delete instance data (tari-project#1059) chore(deps): bump docker/build-push-action from 5 to 6 (tari-project#1061) refactor(wallet_daemon): use the indexer for substate listing (tari-project#1060)
stringhandler
approved these changes
Jun 25, 2024
Merged
via the queue into
tari-project:development
with commit Jun 25, 2024
143006b
11 checks passed
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Jun 26, 2024
* development: feat(swarm): list all running instances (ports etc) (tari-project#1051)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lists all instances in swarm UI
Motivation and Context
Allows the user to easily see all allocated ports and base dir for each running instance. This allows the user to work around the signaling server URL not being specified in the connect link and manually specify the port in e.g. template-web. Since we may change the wallet daemon to allow browser connections through the webtransport, websockets etc using libp2p negating the need for the signaling server, I did not implement changes to the URL.
How Has This Been Tested?
Manually
What process can a PR reviewer use to test or verify this change?
Run swarm
Breaking Changes