Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionization rates #2897

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

andrewfullard
Copy link
Contributor

📝 Description

Type: 🚀 feature

Photo- and collisional ionization rates in the new setup.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Dec 3, 2024

*beep* *bop*
Hi human,
I ran ruff on the latest commit (ce16856).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

13	W291	[*] Trailing whitespace
9	F401	[ ] `tardis.plasma.equilibrium.rates.collision_strengths.UpsilonCMFGENSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
7	E999	[ ] SyntaxError: Expected ',', found ':'
2	W293	[*] Blank line contains whitespace

Complete output(might be large):

.github/workflows/benchmarks.yml:3:4: E999 SyntaxError: Expected an expression
.github/workflows/benchmarks.yml:20:5: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:86:49: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:116:81: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:117:54: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:204:1: W293 [*] Blank line contains whitespace
.github/workflows/benchmarks.yml:223:22: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:224:170: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:226:84: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:243:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:7:4: E999 SyntaxError: Expected an expression
CHANGELOG.md:4:15: E999 SyntaxError: Expected ',', found ':'
CITATION.cff:3:1: E999 SyntaxError: Invalid annotated assignment target
README.rst:1:1: E999 SyntaxError: Expected a statement
docs/contributing/development/running_tests.rst:1:1: E999 SyntaxError: Expected a statement
docs/contributing/development/running_tests.rst:37:42: W291 [*] Trailing whitespace
docs/contributing/development/running_tests.rst:60:112: W291 [*] Trailing whitespace
docs/contributing/development/running_tests.rst:61:124: W291 [*] Trailing whitespace
docs/contributing/development/running_tests.rst:65:92: W291 [*] Trailing whitespace
docs/contributing/development/running_tests.rst:66:107: W291 [*] Trailing whitespace
docs/contributing/development/running_tests.rst:76:62: W291 [*] Trailing whitespace
docs/resources/credits.rst:1:1: E999 SyntaxError: Expected a statement
tardis/plasma/equilibrium/rates/__init__.py:2:5: F401 `tardis.plasma.equilibrium.rates.collision_strengths.UpsilonCMFGENSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/plasma/equilibrium/rates/__init__.py:3:5: F401 `tardis.plasma.equilibrium.rates.collision_strengths.UpsilonRegemorterSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/plasma/equilibrium/rates/__init__.py:6:5: F401 `tardis.plasma.equilibrium.rates.collisional_ionization_rates.CollisionalIonizationSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/plasma/equilibrium/rates/__init__.py:9:5: F401 `tardis.plasma.equilibrium.rates.collisional_ionization_strengths.CollisionalIonizationSeaton` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/plasma/equilibrium/rates/__init__.py:12:5: F401 `tardis.plasma.equilibrium.rates.collisional_rates.ThermalCollisionalRateSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/plasma/equilibrium/rates/__init__.py:15:5: F401 `tardis.plasma.equilibrium.rates.photoionization_strengths.AnalyticPhotoionizationCoeffSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/plasma/equilibrium/rates/__init__.py:16:5: F401 `tardis.plasma.equilibrium.rates.photoionization_strengths.EstimatedPhotoionizationCoeffSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/plasma/equilibrium/rates/__init__.py:17:5: F401 `tardis.plasma.equilibrium.rates.photoionization_strengths.SpontaneousRecombinationCoeffSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/plasma/equilibrium/rates/__init__.py:20:5: F401 `tardis.plasma.equilibrium.rates.radiative_rates.RadiativeRatesSolver` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
Found 31 errors.
[*] 15 fixable with the `--fix` option.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 32.38095% with 71 lines in your changes missing coverage. Please review.

Project coverage is 69.79%. Comparing base (cc0b125) to head (10390fc).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...sma/equilibrium/rates/photoionization_strengths.py 39.28% 34 Missing ⚠️
.../plasma/equilibrium/rates/photoionization_rates.py 0.00% 16 Missing ⚠️
...ilibrium/rates/collisional_ionization_strengths.py 36.36% 14 Missing ⚠️
.../equilibrium/rates/collisional_ionization_rates.py 36.36% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2897      +/-   ##
==========================================
- Coverage   70.39%   69.79%   -0.60%     
==========================================
  Files         221      225       +4     
  Lines       16147    16252     +105     
==========================================
- Hits        11366    11343      -23     
- Misses       4781     4909     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants