Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Modifications #2816

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Sep 2, 2024

📝 Description

Type: | 🎢 infrastructure

Tasks being addressed in this PR-

  1. Changelog in release summary
  2. Updates release action version
  3. Adds arm lockfile to release assets

Sample- https://github.com/atharva-2001/tardis/releases/tag/release-2024.09.02
The items here are large since I did not have a release on my fork since Aug 1.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Sep 2, 2024

*beep* *bop*
Hi human,
I ran ruff on the latest commit (301f327).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

67	I001   	[*] Import block is un-sorted or un-formatted
64	F401   	[*] `astropy.constants` imported but unused
30	D202   	[*] No blank lines allowed after function docstring (found 1)
25	E999   	[ ] SyntaxError: Expected an expression
21	W291   	[*] Trailing whitespace
16	G004   	[ ] Logging statement uses f-string
16	W293   	[*] Blank line contains whitespace
16	F821   	[ ] Undefined name `basestring`
12	INP001 	[ ] File `tardis/analysis/opacities.py` is part of an implicit namespace package. Add an `__init__.py`.
10	UP004  	[*] Class `FilterLog` inherits from `object`
9	F811   	[*] Redefinition of unused `Path` from line 1
8	RET505 	[ ] Unnecessary `elif` after `return` statement
8	UP015  	[*] Unnecessary open mode parameters
7	E402   	[ ] Module level import not at top of file
6	UP008  	[*] Use `super()` instead of `super(__class__, self)`
6	UP031  	[*] Use format specifiers instead of percent format
4	B011   	[*] Do not `assert False` (`python -O` removes these calls), raise `AssertionError()`
4	PT015  	[ ] Assertion always fails, replace with `pytest.fail()`
4	E712   	[*] Avoid equality comparisons to `False`; use `if not ...:` for false checks
4	D409   	[*] Section underline should match the length of its name ("Parameters")
4	D411   	[*] Missing blank line before section ("Parameters")
4	D412   	[*] No blank lines allowed between a section header and its content ("Parameters")
4	PLR1711	[*] Useless `return` statement at end of function
3	C408   	[*] Unnecessary `dict` call (rewrite as a literal)
3	PIE790 	[*] Unnecessary `pass` statement
3	FLY002 	[*] Consider `"\n---\n"` instead of string join
3	D209   	[*] Multi-line docstring closing quotes should be on a separate line
3	F405   	[ ] `deepcopy` may be undefined, or defined from star imports
3	UP024  	[*] Replace aliased errors with `OSError`
3	UP032  	[*] Use f-string instead of `format` call
2	B018   	[ ] Found useless expression. Either assign it to a variable or remove it.
2	C403   	[*] Unnecessary `list` comprehension (rewrite as a `set` comprehension)
2	PT013  	[ ] Incorrect import of `pytest`; use `import pytest` instead
2	RET508 	[ ] Unnecessary `elif` after `break` statement
2	N812   	[ ] Lowercase `__path__` imported as non-lowercase `TARDIS_PATH`
2	F403   	[ ] `from tardis.grid.base import *` used; unable to detect undefined names
1	ANN204 	[ ] Missing return type annotation for special method `__getitem__`
1	B009   	[*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access.
1	B017   	[ ] `pytest.raises(Exception)` should be considered evil
1	C405   	[*] Unnecessary `list` literal (rewrite as a `set` literal)
1	C414   	[*] Unnecessary `list` call within `set()`
1	FA100  	[ ] Add `from __future__ import annotations` to simplify `typing.Tuple`
1	G001   	[ ] Logging statement uses `str.format`
1	PT014  	[*] Duplicate of test case at index 1 in `@pytest_mark.parametrize`
1	PT021  	[ ] Use `yield` instead of `request.addfinalizer`
1	RET506 	[ ] Unnecessary `else` after `raise` statement
1	SIM210 	[*] Remove unnecessary `True if ... else False`
1	PTH117 	[ ] `os.path.isabs()` should be replaced by `Path.is_absolute()`
1	NPY201 	[ ] `np.recfromtxt` will be removed in NumPy 2.0. Use `np.genfromtxt` instead.
1	N999   	[ ] Invalid module name: 'test_HDFWriter'
1	E401   	[*] Multiple imports on one line
1	E701   	[ ] Multiple statements on one line (colon)
1	E713   	[*] Test for membership should be `not in`
1	E722   	[ ] Do not use bare `except`
1	E902   	[ ] No such file or directory (os error 2)
1	W292   	[*] No newline at end of file
1	W605   	[*] Invalid escape sequence: `\g`
1	D406   	[*] Section name should end with a newline ("Returns")
1	D407   	[*] Missing dashed underline after section ("Returns")
1	PGH004 	[ ] Use specific rule codes when using `noqa`
1	UP028  	[*] Replace `yield` over `for` loop with `yield from`
1	UP030  	[*] Use implicit references for positional format fields

Complete output(might be large):

.github/actions/setup_lfs/action.yml:5:8: E999 SyntaxError: Expected an expression
.github/workflows/build-docs.yml:7:4: E999 SyntaxError: Expected an expression
.github/workflows/build-docs.yml:95:1: W293 [*] Blank line contains whitespace
.github/workflows/build-docs.yml:98:14: W291 [*] Trailing whitespace
.github/workflows/dispatcher.yml:2:4: E999 SyntaxError: Expected an expression
.github/workflows/pre-release.yml:7:4: E999 SyntaxError: Expected an expression
.github/workflows/pre-release.yml:33:1: W293 [*] Blank line contains whitespace
.github/workflows/pre-release.yml:35:15: W291 [*] Trailing whitespace
.github/workflows/pre-release.yml:40:1: W293 [*] Blank line contains whitespace
.github/workflows/pre-release.yml:98:37: W291 [*] Trailing whitespace
.github/workflows/pre-release.yml:143:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:7:4: E999 SyntaxError: Expected an expression
.github/workflows/release.yml:16:7: E701 Multiple statements on one line (colon)
.github/workflows/release.yml:57:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:59:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:7:4: E999 SyntaxError: Expected an expression
.github/workflows/tests.yml:29:205: W291 [*] Trailing whitespace
.github/workflows/tests.yml:35:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:39:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:68:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:73:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:78:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:85:142: W291 [*] Trailing whitespace
.github/workflows/tests.yml:86:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:88:163: W291 [*] Trailing whitespace
.github/workflows/tests.yml:90:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:99:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:113:14: W291 [*] Trailing whitespace
.github/workflows/tests.yml:116:1: W293 [*] Blank line contains whitespace
.github/workflows/tests.yml:122:1: W293 [*] Blank line contains whitespace
asv.conf.json:1:1: B018 Found useless expression. Either assign it to a variable or remove it.
asv.conf.json:32:2: W292 [*] No newline at end of file
docs/io/configuration/components/models/data/config_init_trad.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
docs/io/configuration/components/models/data/config_no_init_trad.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
docs/io/visualization/how_to_generating_widgets.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/io/visualization/how_to_generating_widgets.ipynb:cell 5:3:5: F401 [*] `tardis.visualization.shell_info_from_hdf` imported but unused
docs/resources/code_comparison/plasma_compare/tardis_example.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/analysis/opacities.py:1:1: INP001 File `tardis/analysis/opacities.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/analysis/opacities.py:1:1: D209 [*] Multi-line docstring closing quotes should be on a separate line
tardis/analysis/opacities.py:3:1: I001 [*] Import block is un-sorted or un-formatted
tardis/analysis/opacities.py:12:26: UP004 [*] Class `opacity_calculator` inherits from `object`
tardis/analysis/opacities.py:225:9: D209 [*] Multi-line docstring closing quotes should be on a separate line
tardis/analysis/opacities.py:274:9: D209 [*] Multi-line docstring closing quotes should be on a separate line
tardis/analysis/opacities.py:282:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/analysis/opacities.py:329:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/analysis/opacities.py:360:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/analysis/opacities.py:388:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/conftest.py:11:1: F403 `from tardis.tests.fixtures.atom_data import *` used; unable to detect undefined names
tardis/conftest.py:29:49: PGH004 Use specific rule codes when using `noqa`
tardis/conftest.py:31:9: F821 Undefined name `pytest_report_header`
tardis/conftest.py:144:5: RET505 Unnecessary `else` after `return` statement
tardis/conftest.py:229:19: F405 `deepcopy` may be undefined, or defined from star imports
tardis/conftest.py:238:19: F405 `deepcopy` may be undefined, or defined from star imports
tardis/conftest.py:267:19: F405 `deepcopy` may be undefined, or defined from star imports
tardis/energy_input/docs/working_gamma_ray_test.ipynb:cell 1:2:1: I001 [*] Import block is un-sorted or un-formatted
tardis/energy_input/docs/working_gamma_ray_test.ipynb:cell 1:3:18: F401 [*] `pandas` imported but unused
tardis/energy_input/docs/working_gamma_ray_test.ipynb:cell 1:6:29: F401 [*] `astropy.constants` imported but unused
tardis/energy_input/docs/working_gamma_ray_test.ipynb:cell 1:7:25: F401 [*] `astropy.units` imported but unused
tardis/energy_input/docs/working_gamma_ray_test.ipynb:cell 2:2:1: I001 [*] Import block is un-sorted or un-formatted
tardis/energy_input/docs/working_gamma_ray_test.ipynb:cell 7:5:70: W291 [*] Trailing whitespace
tardis/energy_input/docs/working_gamma_ray_test.ipynb:cell 9:3:96: W291 [*] Trailing whitespace
tardis/energy_input/docs/working_gamma_ray_test.ipynb:cell 9:4:99: W291 [*] Trailing whitespace
tardis/energy_input/docs/working_gamma_ray_test.ipynb:cell 9:6:78: W291 [*] Trailing whitespace
tardis/energy_input/docs/working_gamma_ray_test.ipynb:cell 10:2:65: W605 [*] Invalid escape sequence: `\g`
tardis/grid/__init__.py:2:41: W291 Trailing whitespace
tardis/grid/__init__.py:3:37: W291 Trailing whitespace
tardis/grid/__init__.py:7:1: F403 `from tardis.grid.base import *` used; unable to detect undefined names
tardis/grid/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/grid/base.py:7:33: F401 [*] `tardis.io.atom_data.AtomData` imported but unused
tardis/grid/base.py:33:5: PLR1711 [*] Useless `return` statement at end of function
tardis/grid/base.py:70:9: PLR1711 [*] Useless `return` statement at end of function
tardis/grid/base.py:147:9: PLR1711 [*] Useless `return` statement at end of function
tardis/grid/tests/test_grid.py:1:1: INP001 File `tardis/grid/tests/test_grid.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/grid/tests/test_grid.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/grid/tests/test_grid.py:8:21: F811 [*] Redefinition of unused `Path` from line 1
tardis/io/atom_data/__init__.py:2:38: W291 Trailing whitespace
tardis/io/atom_data/__init__.py:5:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/atom_data/__init__.py:5:38: F401 `tardis.io.atom_data.base.AtomData` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/io/atom_data/__init__.py:6:51: F401 `tardis.io.atom_data.atom_web_download.download_atom_data` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/io/atom_data/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/atom_data/base.py:198:34: G004 Logging statement uses f-string
tardis/io/atom_data/base.py:263:17: G004 Logging statement uses f-string
tardis/io/atom_data/base.py:267:21: UP030 Use implicit references for positional format fields
tardis/io/atom_data/base.py:267:21: G001 Logging statement uses `str.format`
tardis/io/atom_data/base.py:704:17: G004 Logging statement uses f-string
tardis/io/atom_data/util.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/atom_data/util.py:8:5: F401 [*] `tardis.io.atom_data.atom_web_download.download_atom_data` imported but unused
tardis/io/atom_data/util.py:15:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/atom_data/util.py:37:13: G004 Logging statement uses f-string
tardis/io/atom_data/util.py:44:15: UP024 [*] Replace aliased errors with `OSError`
tardis/io/atom_data/util.py:50:11: UP024 [*] Replace aliased errors with `OSError`
tardis/io/configuration/config_internal.py:1:1: E401 [*] Multiple imports on one line
tardis/io/configuration/config_internal.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/configuration/config_internal.py:6:20: N812 Lowercase `__path__` imported as non-lowercase `TARDIS_PATH`
tardis/io/configuration/config_internal.py:23:13: G004 Logging statement uses f-string
tardis/io/configuration/config_internal.py:36:13: G004 Logging statement uses f-string
tardis/io/configuration/config_internal.py:49:15: UP024 [*] Replace aliased errors with `OSError`
tardis/io/configuration/config_reader.py:53:29: G004 Logging statement uses f-string
tardis/io/configuration/config_reader.py:88:21: C408 Unnecessary `dict` call (rewrite as a literal)
tardis/io/configuration/config_reader.py:112:21: UP008 Use `super()` instead of `super(__class__, self)`
tardis/io/configuration/config_reader.py:117:9: RET505 Unnecessary `else` after `return` statement
tardis/io/configuration/config_reader.py:118:18: UP008 Use `super()` instead of `super(__class__, self)`
tardis/io/configuration/config_reader.py:141:13: RET505 Unnecessary `else` after `return` statement
tardis/io/configuration/config_reader.py:218:29: G004 Logging statement uses f-string
tardis/io/configuration/config_reader.py:450:14: UP008 Use `super()` instead of `super(__class__, self)`
tardis/io/configuration/config_validator.py:43:9: UP028 Replace `yield` over `for` loop with `yield from`
tardis/io/configuration/tests/test_config_reader.py:1:1: INP001 File `tardis/io/configuration/tests/test_config_reader.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/io/configuration/tests/test_config_reader.py:2:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/configuration/tests/test_config_reader.py:2:8: F401 [*] `os` imported but unused
tardis/io/configuration/tests/test_config_reader.py:3:18: F401 [*] `attr.validate` imported but unused
tardis/io/configuration/tests/test_configuration_namespace.py:1:1: INP001 File `tardis/io/configuration/tests/test_configuration_namespace.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/io/configuration/tests/test_configuration_namespace.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/logger/__init__.py:2:29: W291 Trailing whitespace
tardis/io/logger/colored_logger.py:83:9: PLR1711 [*] Useless `return` statement at end of function
tardis/io/logger/logger.py:4:63: F401 [*] `tardis.io.logger.colored_logger.formatter_message` imported but unused
tardis/io/logger/logger.py:28:17: UP004 [*] Class `FilterLog` inherits from `object`
tardis/io/logger/logger.py:66:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/logger/logger.py:118:12: E713 [*] Test for membership should be `not in`
tardis/io/logger/montecarlo_tracking.py:2:23: F401 [*] `functools.wraps` imported but unused
tardis/io/logger/montecarlo_tracking.py:63:30: G004 Logging statement uses f-string
tardis/io/logger/montecarlo_tracking.py:64:30: G004 Logging statement uses f-string
tardis/io/logger/tests/test_logging.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/logger/tests/test_logging.py:8:8: F811 [*] Redefinition of unused `pytest` from line 1
tardis/io/logger/tests/test_logging.py:70:16: E712 Avoid equality comparisons to `True`; use `if specific_log_level:` for truth checks
tardis/io/logger/tests/test_logging.py:88:16: E712 Avoid equality comparisons to `True`; use `if specific_log_level:` for truth checks
tardis/io/logger/tests/test_logging.py:110:16: E712 Avoid equality comparisons to `True`; use `if specific_log_level:` for truth checks
tardis/io/model/__init__.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/model/__init__.py:1:44: F401 `tardis.io.model.readers.stella.read_stella_model` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/io/model/__init__.py:4:44: F401 `tardis.io.model.readers.cmfgen.read_cmfgen_model` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/io/model/parse_atom_data.py:40:21: G004 Logging statement uses f-string
tardis/io/model/readers/arepo.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/model/readers/arepo.py:19:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/model/readers/arepo.py:129:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/model/readers/arepo.py:178:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/model/readers/arepo.py:256:19: UP032 [*] Use f-string instead of `format` call
tardis/io/model/readers/arepo.py:268:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/model/readers/arepo.py:384:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/model/readers/arepo.py:429:25: UP032 [*] Use f-string instead of `format` call
tardis/io/model/readers/arepo.py:432:25: UP032 [*] Use f-string instead of `format` call
tardis/io/model/readers/arepo.py:453:29: UP031 Use format specifiers instead of percent format
tardis/io/model/readers/arepo.py:454:29: UP031 Use format specifiers instead of percent format
tardis/io/model/readers/arepo.py:461:17: FLY002 Consider `"\n---\n"` instead of string join
tardis/io/model/readers/arepo.py:472:35: UP031 Use format specifiers instead of percent format
tardis/io/model/readers/arepo.py:473:31: UP031 Use format specifiers instead of percent format
tardis/io/model/readers/arepo.py:501:29: UP031 Use format specifiers instead of percent format
tardis/io/model/readers/arepo.py:502:25: UP031 Use format specifiers instead of percent format
tardis/io/model/readers/arepo.py:537:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/model/readers/arepo.py:707:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/model/readers/artis.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/model/readers/artis.py:7:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/model/readers/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/model/readers/base.py:25:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/model/readers/blondin_toymodel.py:31:10: UP015 [*] Unnecessary open mode parameters
tardis/io/model/readers/blondin_toymodel.py:94:10: UP015 [*] Unnecessary open mode parameters
tardis/io/model/readers/cmfgen.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/model/readers/cmfgen.py:4:21: F401 [*] `pathlib.Path` imported but unused
tardis/io/model/readers/cmfgen.py:27:5: D412 [*] No blank lines allowed between a section header and its content ("Parameters")
tardis/io/model/readers/cmfgen_deprecated.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/model/readers/cmfgen_deprecated.py:73:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/model/readers/csvy.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/model/readers/csvy.py:100:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/model/readers/generic_readers.py:1:21: F401 [*] `pathlib.Path` imported but unused
tardis/io/model/readers/generic_readers.py:21:6: FA100 Add `from __future__ import annotations` to simplify `typing.Tuple`
tardis/io/model/readers/generic_readers.py:48:12: NPY201 `np.recfromtxt` will be removed in NumPy 2.0. Use `np.genfromtxt` instead.
tardis/io/model/readers/stella.py:32:5: D412 [*] No blank lines allowed between a section header and its content ("Parameters")
tardis/io/model/readers/stella.py:53:17: RET508 Unnecessary `else` after `break` statement
tardis/io/model/readers/tests/data/csvy_test_config.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/io/model/readers/tests/test_arepo_parser.py:1:1: INP001 File `tardis/io/model/readers/tests/test_arepo_parser.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/io/model/readers/tests/test_arepo_parser.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/model/readers/tests/test_arepo_parser.py:16:10: UP015 [*] Unnecessary open mode parameters
tardis/io/model/readers/tests/test_arepo_parser.py:48:10: UP015 [*] Unnecessary open mode parameters
tardis/io/model/readers/tests/test_arepo_parser.py:59:10: UP015 [*] Unnecessary open mode parameters
tardis/io/model/readers/tests/test_arepo_parser.py:89:10: UP015 [*] Unnecessary open mode parameters
tardis/io/model/readers/tests/test_arepo_parser.py:99:10: UP015 [*] Unnecessary open mode parameters
tardis/io/model/readers/tests/test_arepo_parser.py:109:10: UP015 [*] Unnecessary open mode parameters
tardis/io/model/readers/tests/test_ascii_readers.py:1:1: INP001 File `tardis/io/model/readers/tests/test_ascii_readers.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/io/model/readers/tests/test_ascii_readers.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/model/readers/tests/test_ascii_readers.py:3:20: F401 [*] `tardis.io` imported but unused
tardis/io/model/readers/tests/test_ascii_readers.py:10:17: F401 [*] `numpy` imported but unused
tardis/io/model/readers/tests/test_ascii_readers.py:12:21: F401 [*] `pathlib.Path` imported but unused
tardis/io/model/readers/tests/test_cmfgen_reader.py:1:1: INP001 File `tardis/io/model/readers/tests/test_cmfgen_reader.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/io/model/readers/tests/test_cmfgen_reader.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/model/readers/tests/test_cmfgen_reader.py:5:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
tardis/io/model/readers/tests/test_cmfgen_reader.py:6:30: F401 [*] `astropy.units` imported but unused
tardis/io/model/readers/tests/test_csvy_reader.py:1:1: INP001 File `tardis/io/model/readers/tests/test_csvy_reader.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/io/model/readers/tests/test_csvy_reader.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/model/readers/tests/test_csvy_reader.py:5:38: F401 [*] `jsonschema.exceptions` imported but unused
tardis/io/model/readers/tests/test_csvy_reader.py:8:30: F401 [*] `astropy.units` imported but unused
tardis/io/model/readers/tests/test_csvy_reader.py:48:10: B017 `pytest.raises(Exception)` should be considered evil
tardis/io/model/readers/tests/test_stella_reader.py:1:1: INP001 File `tardis/io/model/readers/tests/test_stella_reader.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/io/model/readers/tests/test_stella_reader.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/model/readers/tests/test_stella_reader.py:5:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
tardis/io/tests/test_HDFWriter.py:1:1: N999 Invalid module name: 'test_HDFWriter'
tardis/io/tests/test_HDFWriter.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/tests/test_HDFWriter.py:6:27: F401 [*] `numpy.testing.assert_almost_equal` imported but unused
tardis/io/tests/test_atomic.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/tests/test_decay.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/tests/test_model_reader.py:1:8: F401 [*] `h5py` imported but unused
tardis/io/util.py:18:20: N812 Lowercase `__path__` imported as non-lowercase `TARDIS_PATH`
tardis/io/util.py:62:24: UP004 [*] Class `MockRegexPattern` inherits from `object`
tardis/io/util.py:163:34: F821 Undefined name `basestring`
tardis/io/util.py:191:22: UP004 [*] Class `HDFWriterMixin` inherits from `object`
tardis/io/util.py:193:25: UP008 Use `super()` instead of `super(__class__, self)`
tardis/io/util.py:239:9: RET506 Unnecessary `else` after `raise` statement
tardis/io/util.py:328:21: G004 Logging statement uses f-string
tardis/io/util.py:385:14: UP008 Use `super()` instead of `super(__class__, self)`
tardis/io/util.py:392:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/util.py:415:13: G004 Logging statement uses f-string
tardis/model/__init__.py:2:44: W291 Trailing whitespace
tardis/model/__init__.py:4:53: W291 Trailing whitespace
tardis/model/__init__.py:5:46: W291 Trailing whitespace
tardis/model/__init__.py:9:31: F401 `tardis.model.base.SimulationState` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/model/base.py:340:12: PTH117 `os.path.isabs()` should be replaced by `Path.is_absolute()`
tardis/model/base.py:353:27: C403 Unnecessary `list` comprehension (rewrite as a `set` comprehension)
tardis/model/base.py:366:27: C403 Unnecessary `list` comprehension (rewrite as a `set` comprehension)
tardis/model/base.py:377:21: G004 Logging statement uses f-string
tardis/model/geometry/radial1d.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/model/geometry/radial1d.py:196:29: UP004 [*] Class `NumbaRadial1DGeometry` inherits from `object`
tardis/model/geometry/tests/test_radial1d.py:1:1: INP001 File `tardis/model/geometry/tests/test_radial1d.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/model/geometry/tests/test_radial1d.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/model/matter/decay.py:20:14: UP008 Use `super()` instead of `super(__class__, self)`
tardis/model/matter/decay.py:28:28: C408 Unnecessary `dict` call (rewrite as a literal)
tardis/model/matter/decay.py:36:30: C405 Unnecessary `list` literal (rewrite as a `set` literal)
tardis/model/matter/decay.py:71:23: C408 Unnecessary `dict` call (rewrite as a literal)
tardis/model/matter/decay.py:101:21: G004 Logging statement uses f-string
tardis/model/matter/decay.py:104:17: G004 Logging statement uses f-string
tardis/model/tests/data/branch85_csvy.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/data/branch85_old_config.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/data/csvy_model_to_test_abundances.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/data/exponential_csvy.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/data/exponential_old_config.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/data/model_full_csvy.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/data/model_full_old_config.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/data/powerlaw_csvy.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/data/powerlaw_old_config.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/data/radiative_csvy.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/data/radiative_old_config.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/data/uniform_csvy.yml:1:69: W291 [*] Trailing whitespace
tardis/model/tests/data/uniform_csvy.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/data/uniform_old_config.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/model/tests/test_base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/model/tests/test_base.py:1:8: F401 [*] `os` imported but unused
tardis/model/tests/test_base.py:2:21: F401 [*] `pathlib.Path` imported but unused
tardis/model/tests/test_csvy_model.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/model/tests/test_csvy_model.py:1:21: F401 [*] `pathlib.Path` imported but unused
tardis/model/tests/test_csvy_model.py:6:30: F401 [*] `astropy.units` imported but unused
tardis/model/tests/test_csvy_model.py:8:38: F401 [*] `tardis.io.atom_data.base.AtomData` imported but unused
tardis/model/tests/test_density.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/model/tests/test_density.py:1:8: F401 [*] `os` imported but unused
tardis/plasma/tests/data/config_init_trad.yml:2:26: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
tardis/plasma/tests/test_complete_plasmas.py:147:27: FLY002 Consider `f"{hash_string}_{prop}"` instead of string join
tardis/plasma/tests/test_complete_plasmas.py:152:39: FLY002 Consider `f"{hash_string}_{nlte_prop}"` instead of string join
tardis/radiation_field/base.py:1:1: INP001 File `tardis/radiation_field/base.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/radiation_field/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/tests/__init__.py:1:1: E902 No such file or directory (os error 2)
tardis/tests/fixtures/atom_data.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/tests/fixtures/atom_data.py:2:21: F401 [*] `pathlib.Path` imported but unused
tardis/transport/frame_transformations.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/frame_transformations.py:19:5: RET505 Unnecessary `else` after `return` statement
tardis/transport/frame_transformations.py:49:5: RET505 Unnecessary `else` after `return` statement
tardis/transport/geometry/calculate_distances.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/geometry/calculate_distances.py:18:5: F401 [*] `tardis.transport.montecarlo.r_packet.print_r_packet_properties` imported but unused
tardis/transport/geometry/calculate_distances.py:24:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/transport/geometry/calculate_distances.py:73:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/transport/montecarlo/__init__.py:2:39: W291 Trailing whitespace
tardis/transport/montecarlo/__init__.py:6:69: W291 Trailing whitespace
tardis/transport/montecarlo/__init__.py:14:1: E402 Module level import not at top of file
tardis/transport/montecarlo/__init__.py:24:1: E402 Module level import not at top of file
tardis/transport/montecarlo/__init__.py:24:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/__init__.py:24:50: F401 `tardis.transport.montecarlo.r_packet.RPacket` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/transport/montecarlo/__init__.py:25:1: E402 Module level import not at top of file
tardis/transport/montecarlo/__init__.py:26:5: F401 `tardis.transport.montecarlo.packet_collections.PacketCollection` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/transport/montecarlo/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/configuration/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/configuration/base.py:7:41: F401 [*] `tardis.transport.montecarlo.montecarlo_main_loop` imported but unused
tardis/transport/montecarlo/configuration/base.py:32:31: UP004 [*] Class `MonteCarloConfiguration` inherits from `object`
tardis/transport/montecarlo/estimators/radfield_estimator_calcs.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/interaction.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/macro_atom.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/macro_atom.py:5:41: F401 [*] `tardis.transport.montecarlo.njit_dict` imported but unused
tardis/transport/montecarlo/nonhomologous_grid.py:20:5: D409 [*] Section underline should match the length of its name ("Returns")
tardis/transport/montecarlo/nonhomologous_grid.py:36:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/transport/montecarlo/nonhomologous_grid.py:40:5: D411 [*] Missing blank line before section ("Parameters")
tardis/transport/montecarlo/nonhomologous_grid.py:46:5: D409 [*] Section underline should match the length of its name ("Returns")
tardis/transport/montecarlo/nonhomologous_grid.py:64:5: D409 [*] Section underline should match the length of its name ("Parameters")
tardis/transport/montecarlo/nonhomologous_grid.py:67:5: D411 [*] Missing blank line before section ("Returns")
tardis/transport/montecarlo/nonhomologous_grid.py:68:5: D409 [*] Section underline should match the length of its name ("Returns")
tardis/transport/montecarlo/numba_interface.py:40:20: UP004 [*] Class `OpacityState` inherits from `object`
tardis/transport/montecarlo/numba_interface.py:66:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/transport/montecarlo/numba_interface.py:115:9: ANN204 Missing return type annotation for special method `__getitem__`
tardis/transport/montecarlo/numba_interface.py:121:9: D407 [*] Missing dashed underline after section ("Returns")
tardis/transport/montecarlo/numba_interface.py:121:9: D406 [*] Section name should end with a newline ("Returns")
tardis/transport/montecarlo/numba_interface.py:156:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/transport/montecarlo/packet_source.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/packet_source.py:228:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/transport/montecarlo/packet_source.py:246:9: RET505 Unnecessary `else` after `return` statement
tardis/transport/montecarlo/packet_source.py:270:9: D412 [*] No blank lines allowed between a section header and its content ("Parameters")
tardis/transport/montecarlo/packet_trackers.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/packet_trackers.py:36:22: UP004 [*] Class `RPacketTracker` inherits from `object`
tardis/transport/montecarlo/packet_trackers.py:39:5: D411 [*] Missing blank line before section ("Parameters")
tardis/transport/montecarlo/packet_trackers.py:203:48: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access.
tardis/transport/montecarlo/packet_trackers.py:223:37: UP004 [*] Class `RPacketLastInteractionTracker` inherits from `object`
tardis/transport/montecarlo/packet_trackers.py:226:5: D411 [*] Missing blank line before section ("Parameters")
tardis/transport/montecarlo/packet_trackers.py:268:9: PIE790 [*] Unnecessary `pass` statement
tardis/transport/montecarlo/packet_trackers.py:275:9: PIE790 [*] Unnecessary `pass` statement
tardis/transport/montecarlo/r_packet.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/r_packet.py:4:18: F401 [*] `pandas` imported but unused
tardis/transport/montecarlo/r_packet.py:14:41: F811 [*] Redefinition of unused `njit_dict_no_parallel` from line 9
tardis/transport/montecarlo/r_packet.py:51:15: UP004 [*] Class `RPacket` inherits from `object`
tardis/transport/montecarlo/r_packet_transport.py:115:13: RET508 Unnecessary `elif` after `break` statement
tardis/transport/montecarlo/single_packet_loop.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_base.py:1:8: F401 [*] `os` imported but unused
tardis/transport/montecarlo/tests/test_base.py:3:17: F401 [*] `numpy` imported but unused
tardis/transport/montecarlo/tests/test_base.py:5:30: F401 [*] `astropy.units` imported but unused
tardis/transport/montecarlo/tests/test_base.py:7:21: F401 [*] `pathlib.Path` imported but unused
tardis/transport/montecarlo/tests/test_interaction.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_macro_atom.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_macro_atom.py:3:17: F401 [*] `numpy` imported but unused
tardis/transport/montecarlo/tests/test_montecarlo.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_montecarlo.py:27:1: E402 Module level import not at top of file
tardis/transport/montecarlo/tests/test_montecarlo.py:32:1: E402 Module level import not at top of file
tardis/transport/montecarlo/tests/test_montecarlo.py:48:5: PT021 Use `yield` instead of `request.addfinalizer`
tardis/transport/montecarlo/tests/test_montecarlo.py:204:5: F811 Redefinition of unused `test_get_random_mu_different_output` from line 195
tardis/transport/montecarlo/tests/test_montecarlo.py:484:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:570:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:571:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:579:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:592:9: PT014 Duplicate of test case at index 1 in `@pytest_mark.parametrize`
tardis/transport/montecarlo/tests/test_montecarlo.py:597:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:602:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:625:9: F821 Undefined name `transport`
tardis/transport/montecarlo/tests/test_montecarlo.py:626:9: F821 Undefined name `transport`
tardis/transport/montecarlo/tests/test_montecarlo.py:627:9: F821 Undefined name `transport`
tardis/transport/montecarlo/tests/test_montecarlo.py:628:9: F821 Undefined name `transport`
tardis/transport/montecarlo/tests/test_montecarlo.py:630:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:643:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:667:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:680:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo_main_loop.py:11:5: PT015 Assertion always fails, replace with `pytest.fail()`
tardis/transport/montecarlo/tests/test_montecarlo_main_loop.py:11:12: B011 Do not `assert False` (`python -O` removes these calls), raise `AssertionError()`
tardis/transport/montecarlo/tests/test_numba_interface.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_numba_interface.py:80:5: PT015 Assertion always fails, replace with `pytest.fail()`
tardis/transport/montecarlo/tests/test_numba_interface.py:80:12: B011 Do not `assert False` (`python -O` removes these calls), raise `AssertionError()`
tardis/transport/montecarlo/tests/test_opacities.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_packet.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_packet.py:8:38: F811 [*] Redefinition of unused `opacities` from line 4
tardis/transport/montecarlo/tests/test_packet.py:9:50: F811 [*] Redefinition of unused `frame_transformations` from line 5
tardis/transport/montecarlo/tests/test_packet.py:10:57: F811 [*] Redefinition of unused `calculate_distances` from line 6
tardis/transport/montecarlo/tests/test_packet.py:12:55: F401 [*] `tardis.transport.montecarlo.numba_interface` imported but unused
tardis/transport/montecarlo/tests/test_packet.py:15:50: F811 [*] Redefinition of unused `frame_transformations` from line 9
tardis/transport/montecarlo/tests/test_packet.py:16:57: F811 [*] Redefinition of unused `calculate_distances` from line 10
tardis/transport/montecarlo/tests/test_packet.py:27:1: E402 Module level import not at top of file
tardis/transport/montecarlo/tests/test_packet_source.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_packet_source.py:1:8: F401 [*] `os` imported but unused
tardis/transport/montecarlo/tests/test_packet_source.py:5:18: F401 [*] `pandas` imported but unused
tardis/transport/montecarlo/tests/test_packet_source.py:13:51: F401 [*] `tardis.tests.fixtures.regression_data.RegressionData` imported but unused
tardis/transport/montecarlo/tests/test_rpacket_last_interaction_tracker.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_rpacket_tracker.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_single_packet_loop.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_single_packet_loop.py:52:5: PT015 Assertion always fails, replace with `pytest.fail()`
tardis/transport/montecarlo/tests/test_single_packet_loop.py:52:12: B011 Do not `assert False` (`python -O` removes these calls), raise `AssertionError()`
tardis/transport/montecarlo/tests/test_single_packet_loop.py:57:5: PT015 Assertion always fails, replace with `pytest.fail()`
tardis/transport/montecarlo/tests/test_single_packet_loop.py:57:12: B011 Do not `assert False` (`python -O` removes these calls), raise `AssertionError()`
tardis/transport/montecarlo/tests/test_tracker_utils.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_tracker_utils.py:1:8: F401 [*] `pytest` imported but unused
tardis/transport/montecarlo/tests/test_vpacket.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_vpacket.py:1:8: F401 [*] `os` imported but unused
tardis/transport/montecarlo/tests/test_vpacket.py:4:18: F401 [*] `pandas` imported but unused
tardis/transport/montecarlo/tests/test_vpacket.py:14:1: E402 Module level import not at top of file
tardis/transport/montecarlo/tests/test_weighted_packet_source.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/tests/test_weighted_packet_source.py:1:8: F401 [*] `os` imported but unused
tardis/transport/montecarlo/tests/test_weighted_packet_source.py:4:17: F401 [*] `numpy` imported but unused
tardis/transport/montecarlo/tests/test_weighted_packet_source.py:5:18: F401 [*] `pandas` imported but unused
tardis/transport/montecarlo/tests/test_weighted_packet_source.py:12:51: F401 [*] `tardis.tests.fixtures.regression_data.RegressionData` imported but unused
tardis/transport/montecarlo/utils.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/weighted_packet_source.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/weighted_packet_source.py:1:19: F401 [*] `numexpr` imported but unused
tardis/transport/montecarlo/weighted_packet_source.py:2:17: F401 [*] `numpy` imported but unused
tardis/transport/montecarlo/weighted_packet_source.py:3:34: F401 [*] `astropy.constants` imported but unused
tardis/transport/montecarlo/weighted_packet_source.py:7:5: F401 [*] `tardis.transport.montecarlo.packet_source.BasePacketSource` imported but unused
tardis/transport/montecarlo/weighted_packet_source.py:8:5: F401 [*] `tardis.transport.montecarlo.packet_source.HDFWriterMixin` imported but unused
tardis/transport/montecarlo/weighted_packet_source.py:84:13: B018 Found useless expression. Either assign it to a variable or remove it.
tardis/transport/tests/test_doppler_factor.py:1:1: INP001 File `tardis/transport/tests/test_doppler_factor.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/transport/tests/test_doppler_factor.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/tests/test_doppler_factor.py:2:17: F401 [*] `numpy` imported but unused
tardis/transport/tests/test_doppler_factor.py:5:48: F401 [*] `tardis.transport.montecarlo.r_packet` imported but unused
tardis/util/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/util/base.py:12:30: F401 [*] `radioactivedecay.Nuclide` imported but unused
tardis/util/base.py:119:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/util/base.py:135:12: C414 Unnecessary `list` call within `set()`
tardis/util/base.py:196:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/util/base.py:234:13: PIE790 [*] Unnecessary `pass` statement
tardis/util/base.py:344:5: RET505 Unnecessary `else` after `return` statement
tardis/util/base.py:349:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/util/base.py:405:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/util/base.py:483:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/util/base.py:502:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/util/base.py:522:5: E722 Do not use bare `except`
tardis/util/base.py:523:22: SIM210 Remove unnecessary `True if ... else False`
tardis/util/base.py:630:5: RET505 Unnecessary `elif` after `return` statement
tardis/util/base.py:776:5: D412 [*] No blank lines allowed between a section header and its content ("Parameters")
tardis/visualization/widgets/line_info.py:3:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/widgets/line_info.py:3:8: F401 [*] `re` imported but unused
tardis/visualization/widgets/line_info.py:8:8: F401 [*] `qgrid` imported but unused
tardis/visualization/widgets/line_info.py:306:21: E712 Avoid equality comparisons to `False`; use `if not ...:` for false checks
tardis/visualization/widgets/util.py:3:1: I001 [*] Import block is un-sorted or un-formatted
tardis_env3.yml:3:10: E999 SyntaxError: Expected an expression
Found 408 errors.
[*] 243 fixable with the `--fix` option (43 hidden fixes can be enabled with the `--unsafe-fixes` option).

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.72%. Comparing base (be4ec9a) to head (301f327).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2816      +/-   ##
==========================================
- Coverage   70.96%   70.72%   -0.25%     
==========================================
  Files         209      209              
  Lines       15638    15589      -49     
==========================================
- Hits        11098    11025      -73     
- Misses       4540     4564      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (be4ec9a) and the latest commit (532da47).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

All benchmarks:

Benchmarks that have stayed the same:

| Change   | Before [be4ec9a4] <master>   | After [532da47c]    | Ratio   | Benchmark (Parameter)                                                                                                               |
|----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------|
|          | 1.98±1μs                     | 2.36±1μs            | ~1.19   | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators       |
|          | 1.28±0.4μs                   | 1.51±0.3μs          | ~1.18   | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line                    |
|          | 45.7±30μs                    | 50.7±20μs           | ~1.11   | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter                                          |
|          | 4.21±0ms                     | 3.49±0.01ms         | ~0.83   | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom')                                   |
|          | 51.3±20μs                    | 53.2±30μs           | 1.04    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission                                         |
|          | 32.6±10μs                    | 33.8±10μs           | 1.04    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list |
|          | 723±2ns                      | 744±0.6ns           | 1.03    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter                                       |
|          | 3.07±0.7μs                   | 3.17±0.5μs          | 1.03    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket                                       |
|          | 541±200ns                    | 551±200ns           | 1.02    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation                              |
|          | 6.27±0.8μs                   | 6.41±1μs            | 1.02    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket                                           |
|          | 1.05±0m                      | 1.06±0m             | 1.01    | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking                                                                      |
|          | 1.20±0μs                     | 1.21±0μs            | 1.01    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary                |
|          | 531±200ns                    | 531±100ns           | 1.00    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation                                      |
|          | 39.6±0.02s                   | 39.6±0.03s          | 1.00    | run_tardis.BenchmarkRunTardis.time_run_tardis                                                                                       |
|          | 2.07±0m                      | 2.07±0m             | 1.00    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions                                 |
|          | 2.58±0.01ms                  | 2.53±0.01ms         | 0.98    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter')                                     |
|          | 31.3±0.01μs                  | 30.5±0.01μs         | 0.98    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list                  |
|          | 65.1±0.3ms                   | 63.2±0.05ms         | 0.97    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe                  |
|          | 1.76±0.02ms                  | 1.68±0.01ms         | 0.96    | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop                             |
|          | 3.35±0.6μs                   | 3.19±0.6μs          | 0.95    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell                              |
|          | 631±100ns                    | 591±200ns           | 0.94    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation                                |
|          | 7.60±2μs                     | 7.15±1μs            | 0.94    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley                                    |
|          | 2.66±0.4ms                   | 2.47±0.4ms          | 0.93    | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop                        |
|          | 222±2ns                      | 202±0.1ns           | 0.91    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body                                       |

If you want to see the graph of the results, you can check it here

andrewfullard
andrewfullard previously approved these changes Sep 3, 2024
@andrewfullard
Copy link
Contributor

Update PR once git-cliff is in lockfile

@andrewfullard andrewfullard merged commit 14013c1 into tardis-sn:master Sep 30, 2024
15 of 18 checks passed
CePowers pushed a commit to CePowers/tardis that referenced this pull request Oct 1, 2024
* Update create pull request action

* Add arm lock file

* Modifications for displaying vhangelog

* Test on fork

* Undo changes to test on fork

* Test git cliff pinned

* Reset release triggers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants