-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V inner boundary solver workflow #2797
base: master
Are you sure you want to change the base?
Conversation
Solvers pass info to each other Simplified some parts
Also adds docstrings to methods. Updates some methods to use new functionality of the plasma. Adds requirements for the convergence plots (still broken)
…wfullard/tardis into v_inner_solver_restructure
Also adds docstrings to methods. Updates some methods to use new functionality of the plasma. Adds requirements for the convergence plots (still broken)
…wfullard/tardis into v_inner_solver_restructure
…nt robot overlords
…wfullard/tardis into v_inner_solver_restructure
|
||
class InnerVelocitySimulationSolver(SimpleSimulation): | ||
|
||
TAU_TARGET = np.log(2.0 / 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For style reasons I would prefer 2. / 3.
|
||
TAU_TARGET = np.log(2.0 / 3) | ||
|
||
def __init__(self, configuration, mean_optical_depth="rossland", tau=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's spelled rosseland
Extrapolate with exponential fits | ||
|
||
Need some way to return and inspect the optical depths for later logging""" | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does nothing, currently?
self.plasma_solver.plasma_solver_settings.RADIATIVE_RATES_TYPE | ||
== "dilute-blackbody" | ||
): | ||
j_blues = radiation_field.calculate_mean_intensity( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these not need to be masked in the same way as for detailed rates?
planckian_radiation_field = ( | ||
radiation_field.to_planckian_radiation_field() | ||
) | ||
j_blues = planckian_radiation_field.calculate_mean_intensity( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these not need to be masked in the same way as for detailed rates?
@Rodot- this needs to be rebased now |
📝
Adds a workflow to solve for the v_inner_boundary of the simulation
Based on PR #2730 Which should be merged first
Type: 🚀
feature
This adds a complete workflow as a subclass of the SimpleSimulation workflow from PR #2730. This workflow adds convergence criteria and handling the the inner-boundary velocity value. This PR also makes small edits to the configuration schema and parser to allow accessing properties of the v_inner_boundary convergence.
📌 Resources
A notebook is provided in tardis/docs/workflows
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label