-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[restructure/plasma] Cleanup plasma assembly #2748
Merged
andrewfullard
merged 115 commits into
tardis-sn:master
from
wkerzendorf:restructure/assemble_plasma_cleanup
Aug 12, 2024
Merged
Changes from 112 commits
Commits
Show all changes
115 commits
Select commit
Hold shift + click to select a range
d583510
change numberdensity to input
wkerzendorf 7aaba5d
fixed number density
wkerzendorf 32b22ea
some fixes
wkerzendorf 261bbad
removing density
wkerzendorf df3c406
remove atomic and isotope mass
wkerzendorf d05e819
add isotopic_number_density
wkerzendorf 61f3db5
Merge remote-tracking branch 'upstream/master' into restructure/plasm…
wkerzendorf e804942
add opacities package
wkerzendorf e573f16
Update imports in property_collections.py, base.py, test_numba_interf…
wkerzendorf 73f2ddc
Add calculate_transition_probabilities function to util.py in macro_a…
wkerzendorf 52d5523
Add calculate_transition_probabilities function to util.py in macro_a…
wkerzendorf 9530fee
Remove unused imports and update plasma properties
wkerzendorf 2fb7f92
add __init__ to macroatom
wkerzendorf 6ac3e88
blackify tardis
wkerzendorf 801c92b
blackified
wkerzendorf ae0650d
chore: Update imports and remove unused code
wkerzendorf 69dc1b5
chore: Add PlanckRadiationField and DilutePlanckRadiationField classes
wkerzendorf 448d5c4
chore: Update imports and remove unused code
wkerzendorf c1dc52d
removed density
wkerzendorf f053967
Merge remote-tracking branch 'upstream/master' into restructure/plasm…
wkerzendorf 17c033c
Merge branch 'restructure/plasma_prepare' into restructure/plasma_opa…
wkerzendorf 5e02054
ruff output
wkerzendorf 28c4348
cleanup and adding object mode
wkerzendorf cfffe5b
starting to make radiation_field a thing
wkerzendorf 4e68723
Merge remote-tracking branch 'upstream/master' into restructure/plasm…
wkerzendorf 41779e2
switched over to old tau_sobolev calculation
wkerzendorf 0d1bc4d
renamed function to indicate numba use
wkerzendorf 7cc84a2
Merge branch 'restructure/plasma_opacities' into restructure/plasma_r…
wkerzendorf c924749
address comments
wkerzendorf ad5a314
Merge branch 'restructure/plasma_opacities' into restructure/plasma_r…
wkerzendorf af7e39e
added dilute planckian radiation field
wkerzendorf 36fa4b6
refactor: Convert species lists to proper format in assemble_plasma f…
wkerzendorf 4bc0dd7
moved radiation field into plasma. Resulting in some renames
wkerzendorf 863f281
Merge remote-tracking branch 'upstream/master' into restructure/plasm…
wkerzendorf 2f042f2
some fixes
wkerzendorf d849f85
black montecarlo
wkerzendorf 3379062
Merge remote-tracking branch 'upstream/master' into restructure/plasm…
wkerzendorf 6feefbe
Merge branch 'restructure/plasma_opacities' into restructure/plasma_r…
wkerzendorf 1786436
chore: Initialize atom data and simulation state in `initialization.py`
wkerzendorf 5740708
updating the documentation
wkerzendorf 92f4e90
feat: Add EstimatedRadiationFieldProperties class for Monte Carlo est…
wkerzendorf e3f1819
trying to get rid of j_blues in plasma with MC restructure
wkerzendorf a99fbb8
completely restructure j_blues. Estimators and all.
wkerzendorf 2d7e1c5
cleanup for the restructure
wkerzendorf 63e0e0c
Merge remote-tracking branch 'upstream/master' into restructure/plasm…
wkerzendorf 818c6d4
remove parse_input.py
wkerzendorf 3ec64f1
chore: Refactor radiation field configuration parsing and state creation
wkerzendorf f1f0cdd
revert astropy_helpers
wkerzendorf 2a7d460
remove astropy_helpers
wkerzendorf dbc34ac
removed test.txt
wkerzendorf 251d1cb
blackified code
wkerzendorf e80b15c
Merge branch 'restructure/plasma_radiation_field' into restructure/si…
wkerzendorf 8581bed
Merge branch 'restructure/simulation_from_config_cleanup' into restru…
wkerzendorf d49a49c
cleanup simulation from merges
wkerzendorf adbaf7f
fix
wkerzendorf bb19fdb
remove unused Input
wkerzendorf aca1099
added description
wkerzendorf 44ffcf9
Merge branch 'restructure/plasma_radiation_field' into restructure/si…
wkerzendorf 54ffe68
blackiefied codebase
wkerzendorf 71a2b13
Merge branch 'restructure/simulation_from_config_cleanup' into restru…
wkerzendorf 2ea3122
cleanup of branch
wkerzendorf 9800fc8
blackify code
wkerzendorf 5914618
Merge branch 'restructure/plasma_radiation_field' into restructure/si…
wkerzendorf d19e423
chore: Refactor atom data parsing and simulation state initialization
wkerzendorf 49b9819
Merge branch 'restructure/simulation_from_config_cleanup' into restru…
wkerzendorf b3bf356
restructure logger
wkerzendorf a22223e
Merge branch 'restructure/simulation_from_config_cleanup' into restru…
wkerzendorf 734ffc8
working on continuum radfield properties
wkerzendorf d69533a
Refactor continuum processes module structure
wkerzendorf 98f8340
Refactor opacities module structure
wkerzendorf 84671ca
cleanup from restructure
wkerzendorf bf25313
Merge remote-tracking branch 'upstream/master' into restructure/base_…
wkerzendorf 7782d07
cleanup
wkerzendorf cfc5078
clean up
wkerzendorf ee864bb
more cleanup
wkerzendorf ad4f1b1
Merge remote-tracking branch 'upstream/master' into restructure/base_…
wkerzendorf 0ebcef8
cleanup standard_plasmas.py
wkerzendorf cf1396a
working nlte ionizations
wkerzendorf 557dde9
Merge remote-tracking branch 'upstream/master' into restructure/base_…
wkerzendorf fcf2563
start of assemble plasma cleanup
wkerzendorf 8324074
cleanup standard_plasmas.py
wkerzendorf 60239f8
updated tests
wkerzendorf 5e4902a
some more cleanup
wkerzendorf 9f92256
fix benchmarks
wkerzendorf 3c7ee67
cleanup assembly
wkerzendorf 0890747
cleanup assembly
wkerzendorf cd1badc
Merge remote-tracking branch 'upstream/master' into restructure/base_…
wkerzendorf 7540e55
working on the restructure
wkerzendorf bd04642
Merge remote-tracking branch 'upstream/master' into restructure/base_…
wkerzendorf e29ae22
slowly fixing the assembly module
wkerzendorf 930462f
blackify
wkerzendorf 9e47b81
reverse the import pygraphviz
wkerzendorf 8d67db8
fix docstrings
wkerzendorf f6f3160
fixed all plasma
wkerzendorf 7f1c301
slow fixes
wkerzendorf e05aeca
Refactor recomb_rate_coeff.py and test_continuum_property_solver.py
wkerzendorf efdb5b1
fixing assembly
wkerzendorf 9078307
restructure the read in
wkerzendorf 683e811
fixup plasma assemble to be clean
wkerzendorf d381f02
fix shell info widget
wkerzendorf fcce9e0
fix the widgets
wkerzendorf ac141ec
fixing hopefully last bugs
wkerzendorf 01b4df7
slowly fix up assembly
wkerzendorf 4ba4afb
working on getting the notebook running
wkerzendorf 7d8e6e0
Refactor code to address comments
wkerzendorf 03e1aae
Merge branch 'restructure/base_estimator_cleanup' into restructure/as…
wkerzendorf 9f93d84
remove abundance
wkerzendorf b5839a6
Merge remote-tracking branch 'upstream/master' into restructure/assem…
wkerzendorf 31bfec6
added pydantic
wkerzendorf 88aff49
possible fix for test problem
wkerzendorf c4dec6f
Merge remote-tracking branch 'upstream/master' into restructure/assem…
wkerzendorf dcd157f
fix problem with opacity solver
wkerzendorf ed750c4
chore: Refactor plasma assembly base and notebook
wkerzendorf 554fa7e
added docstrings
wkerzendorf 573b5e5
Merge remote-tracking branch 'upstream/master' into restructure/assem…
wkerzendorf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to be useful documentation? Not sure what "SCRUN MAGIC" is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it