Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plasma State #2743

Closed
wants to merge 3 commits into from
Closed

Plasma State #2743

wants to merge 3 commits into from

Conversation

Rodot-
Copy link
Contributor

@Rodot- Rodot- commented Jul 25, 2024

📝 Add new state objects that represent the state of the plasma as well as it's components

Type: 🚀 feature | ☣️ breaking change | 🎢 infrastructure

New State objects to keep track of the plasma for use with other solvers. Currently, this PR contains the following:

  • PlasmaState

    • The base plasma properties that are required regardless of the settings, this acts as a container for extra features
  • MacroAtomState

    • The state of the macro atom and associated data
  • ContinuumState

    • The state of the continuum

Please comment on this PR for suggestions and ideas on how to improve the implementation or how to break down the plasma further

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 39.02439% with 75 lines in your changes missing coverage. Please review.

Project coverage is 68.84%. Comparing base (026cf03) to head (0b05bf5).

Files Patch % Lines
tardis/opacities/opacity_state.py 38.82% 52 Missing ⚠️
tardis/plasma/plasma_state.py 39.47% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2743      +/-   ##
==========================================
- Coverage   69.65%   68.84%   -0.82%     
==========================================
  Files         188      189       +1     
  Lines       14930    15053     +123     
==========================================
- Hits        10400    10363      -37     
- Misses       4530     4690     +160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wkerzendorf wkerzendorf marked this pull request as draft July 25, 2024 17:53
…rom 'legacy plasma', more work to be done (maybe remove the MacroAtomState?)
@Rodot- Rodot- closed this Aug 1, 2024
@Rodot- Rodot- deleted the plasma_state branch August 1, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant