-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds number_of_packets property to the packet collection #2740
Adds number_of_packets property to the packet collection #2740
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2740 +/- ##
===========================================
+ Coverage 36.58% 69.12% +32.54%
===========================================
Files 186 188 +2
Lines 14859 14946 +87
===========================================
+ Hits 5436 10332 +4896
+ Misses 9423 4614 -4809 ☔ View full report in Codecov by Sentry. |
Is this sensible? Should this not be a property? |
I don't know if jitclasses can use the @Property decorator. I'll look into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
📝 Description
Type: 🚀
feature
Fixes #2738 by adding the number to the packet collection. Better option than in the transport state.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label