Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds number_of_packets property to the packet collection #2740

Merged

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Jul 24, 2024

📝 Description

Type: 🚀 feature

Fixes #2738 by adding the number to the packet collection. Better option than in the transport state.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.12%. Comparing base (38a35c3) to head (46c7d0f).
Report is 8 commits behind head on master.

Files Patch % Lines
tardis/transport/montecarlo/packet_collections.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2740       +/-   ##
===========================================
+ Coverage   36.58%   69.12%   +32.54%     
===========================================
  Files         186      188        +2     
  Lines       14859    14946       +87     
===========================================
+ Hits         5436    10332     +4896     
+ Misses       9423     4614     -4809     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wkerzendorf
Copy link
Member

Is this sensible? Should this not be a property?

@andrewfullard
Copy link
Contributor Author

Is this sensible? Should this not be a property?

I don't know if jitclasses can use the @Property decorator. I'll look into it.

Rodot-
Rodot- previously approved these changes Jul 25, 2024
Copy link
Contributor

@Rodot- Rodot- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@tardis-bot
Copy link
Contributor

tardis-bot commented Jul 26, 2024

*beep* *bop*
Hi human,
I ran ruff on the latest commit (46c7d0f).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

Complete output(might be large):

@wkerzendorf wkerzendorf merged commit 9590f0b into tardis-sn:master Jul 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a real packet count property to the transport state
4 participants