Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre Release Workflow Fix #2721

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

atharva-2001
Copy link
Member

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

I should not have specified @master when calling the reusable tests workflow. This PR fixes that.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.57%. Comparing base (b8ec53f) to head (5ef39d2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2721   +/-   ##
=======================================
  Coverage   36.57%   36.57%           
=======================================
  Files         184      184           
  Lines       14765    14765           
=======================================
  Hits         5401     5401           
  Misses       9364     9364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atharva-2001
Copy link
Member Author

@atharva-2001 atharva-2001 marked this pull request as ready for review July 22, 2024 12:04
@andrewfullard andrewfullard merged commit fea0ff0 into tardis-sn:master Jul 22, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants