Weighted Packet Sampler #2718
Weighted Packet Sampler #2718
Conversation
…formly in frequency space then assigns energy to each packet based on their black body amplitude
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2718 +/- ##
===========================================
+ Coverage 36.47% 69.27% +32.79%
===========================================
Files 183 191 +8
Lines 14664 15018 +354
===========================================
+ Hits 5348 10403 +5055
+ Misses 9316 4615 -4701 ☔ View full report in Codecov by Sentry. |
…gainst the regression data for the montecarlo_main_loop with the default packet source
|
*beep* *bop* Significantly changed benchmarks: · Did not find results for commit 40e14c23b82ea280288e39838aadda0b880dcebb
All benchmarks: · Did not find results for commit 40e14c23b82ea280288e39838aadda0b880dcebb
If you want to see the graph of the results, you can check it here |
| npt.assert_allclose( | ||
| actual_nu_bar_estimator, expected_nu_bar_estimator, rtol=1e-2 | ||
| ) | ||
| npt.assert_allclose(actual_j_estimator, expected_j_estimator, rtol=1e-2) |
There was a problem hiding this comment.
Why are you using rtol upto two decimal places?
There was a problem hiding this comment.
Because it is checking consistency with the default sampler rather than with itself. It is to make sure we're getting approximately the same solution
There was a problem hiding this comment.
I am happy to approve if the tests passes.
…ighted packet source
|
Tests are failing because the classes aren't inheriting properly it seems. |
|
It would be nice to have a demonstrative notebook |
Since there's already a notebook for using custom samplers, it might be better to wait until we have a workflow that can demonstrate it |
📝 Description
Type: 🚀
featureCreates a basic weighted packet sampler. This sampler samples packets uniformly in frequency and then assigns energy weights based on the corresponding black body intensity at each frequency.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel