Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Continuum Tests #2699

Merged
merged 29 commits into from
Jul 17, 2024

Conversation

atharva-2001
Copy link
Member

📝 Description

Type: | 🚦 testing | 🎢 infrastructure

Made on top of #2698.
Will separate regular and continuum tests into two jobs.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@atharva-2001 atharva-2001 marked this pull request as draft July 12, 2024 03:57
@atharva-2001 atharva-2001 force-pushed the separate_continuum_tests branch 6 times, most recently from d2d02e3 to 2e214ca Compare July 16, 2024 04:41
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.74%. Comparing base (681bd2b) to head (16672c7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2699       +/-   ##
===========================================
- Coverage   68.07%   36.74%   -31.34%     
===========================================
  Files         182      182               
  Lines       14481    14481               
===========================================
- Hits         9858     5321     -4537     
- Misses       4623     9160     +4537     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atharva-2001 atharva-2001 marked this pull request as ready for review July 16, 2024 06:23
@atharva-2001
Copy link
Member Author

I will address the osx-arm64-pip-false Expected — Waiting for status to be reported once the PR is merged. I wouldn't want the check to go away from other pull requests until this is merged.

@atharva-2001 atharva-2001 added the run-generation-tests Run refdata generation tests on pull requests label Jul 17, 2024
atharva-2001 added a commit to atharva-2001/tardis that referenced this pull request Jul 17, 2024
@andrewfullard
Copy link
Contributor

It's odd that the refdata generation tests are taking longer than the regular tests. The codecov errors are also interesting, I guess we need to fix some minor path-related bugs?

@atharva-2001
Copy link
Member Author

It's odd that the refdata generation tests are taking longer than the regular tests. The codecov errors are also interesting, I guess we need to fix some minor path-related bugs?

I agree, but I don't know why they take so long. The markers are the same in both the tests, when one is disabled it seems to take the same time. When both are disabled it takes longer.
In both the tests it says this-

collected 1900 items / 24 deselected / 1876 selected
collected 1900 items / 24 deselected / 1876 selected

Perhaps it the nature?
https://github.com/tardis-sn/tardis/actions/runs/9968496268/job/27543877401?pr=2699

They do take slightly longer usually, right?
https://github.com/tardis-sn/tardis/actions/runs/9595970972/job/26522577969

The codecov is a separate job entirely now so it runs only once. I think the way the report is generated is the same, the way it is sent to the website is different. I thought fixing the codecov issues would be too much for the pull request, is it alright if I address it in a new one?

Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dealing with the sudden changes!

@atharva-2001
Copy link
Member Author

No problem!

@andrewfullard andrewfullard merged commit c107f27 into tardis-sn:master Jul 17, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure run-generation-tests Run refdata generation tests on pull requests testing 🚦
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants