-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Continuum Tests #2699
Separate Continuum Tests #2699
Conversation
d2d02e3
to
2e214ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2699 +/- ##
===========================================
- Coverage 68.07% 36.74% -31.34%
===========================================
Files 182 182
Lines 14481 14481
===========================================
- Hits 9858 5321 -4537
- Misses 4623 9160 +4537 ☔ View full report in Codecov by Sentry. |
I will address the |
0b72303
to
16672c7
Compare
It's odd that the refdata generation tests are taking longer than the regular tests. The codecov errors are also interesting, I guess we need to fix some minor path-related bugs? |
I agree, but I don't know why they take so long. The markers are the same in both the tests, when one is disabled it seems to take the same time. When both are disabled it takes longer.
Perhaps it the nature? They do take slightly longer usually, right? The codecov is a separate job entirely now so it runs only once. I think the way the report is generated is the same, the way it is sent to the website is different. I thought fixing the codecov issues would be too much for the pull request, is it alright if I address it in a new one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for dealing with the sudden changes!
No problem! |
📝 Description
Type: | 🚦
testing
| 🎢infrastructure
Made on top of #2698.
Will separate regular and continuum tests into two jobs.
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label