Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging - avoid the zero division warning #2695

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Logging - avoid the zero division warning #2695

merged 2 commits into from
Jul 11, 2024

Conversation

DeerWhale
Copy link
Contributor

@DeerWhale DeerWhale commented Jul 10, 2024 •
edited
Loading

📝 Description

Type: TARDIS-con hack project - Intending to fix the following warning in TARDIS simulation:

[py.warnings ][WARNING]
/home/runner/work/tardis/tardis/tardis/plasma/properties/radiative_properties.py:90: RuntimeWarning: invalid value encountered in divide
(g_lower * n_upper) / (g_upper * n_lower)
(warnings.py:112)

This contribute to the partial fix of the issue #2534

@DeerWhale DeerWhale changed the title avoid the warning of division zero Logging - avoid the zero division warning Jul 10, 2024
@andrewfullard andrewfullard self-requested a review July 10, 2024 18:04
@andrewfullard andrewfullard self-assigned this Jul 10, 2024
@andrewfullard andrewfullard removed their assignment Jul 10, 2024
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@andrewfullard andrewfullard enabled auto-merge (squash) July 10, 2024 20:45
@wkerzendorf wkerzendorf self-requested a review July 11, 2024 13:20
@andrewfullard andrewfullard merged commit 9279330 into tardis-sn:master Jul 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewfullard andrewfullard andrewfullard approved these changes

@wkerzendorf wkerzendorf wkerzendorf approved these changes

@chvogl chvogl Awaiting requested review from chvogl

Assignees
No one assigned
Labels
bugfix 🪲 build-docs logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeerWhale @tardis-bot @wkerzendorf @andrewfullard