Last Interaction Velocity #2677

sarthak-dv · 2024-06-24T17:41:36Z

📝 Description

Type: 🚀 feature

This PR is in continuation of the PR #2651 which part of the Velocity Packet Tracker Visualisation tool. It introduces a new Python script interaction_radius_plot.py containing the InteractionRadiusPlotter class and a Jupyter notebook interaction_radius_plot.ipynb to demonstrate accessing the class and visualizing the plot.
The plots are generated using both Matplotlib and Plotly.

This PR aims to discuss and finalize the look and feel of the Last Interaction Radius plot.

Refer: #2651

Matplotlib:

Plotly:

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

Testing pipeline
Other method (describe)
My changes can't be tested (explain why)

☑️ Checklist

I requested two reviewers for this pull request
I updated the documentation according to my changes
I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

review-notebook-app · 2024-06-24T17:41:41Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

tardis-bot · 2024-06-24T18:03:31Z

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

sarthak-dv · 2024-06-28T13:31:17Z

I have added a log_scale to the plot and a bins_range filter with which we can select the range of shells we want to plot:

@jamesgillanders @MarkMageeAstro @jaladh-singhal Please review this, Thanks!

jaladh-singhal

This is coming along very nicely - thanks for adressing most of the past comments @sarthak-dv 🎉

I have few more comments to clean it up further. Besides that I don't see you adding your notebook to TOC. Also outputs need to be cleared. Please follow https://tardis-sn.github.io/tardis/contributing/development/documentation_guidelines.html which involves building docs locally to test if they appear ok and then making a docs-website build for us that we can test.

Overall, great job - I hope you are learning more about modularization and documentation through this.

tardis/transport/montecarlo/tests/test_numba_interface.py

tardis/visualization/tools/interaction_radius_plot.py

tardis/visualization/plot_util.py

tardis/visualization/tools/sdec_plot.py

tardis/visualization/tools/interaction_radius_plot.py

docs/io/visualization/interaction_radius_plot.ipynb

docs/io/visualization/how_to_liv_plot.ipynb

jamesgillanders · 2024-07-09T14:19:17Z

docs/io/visualization/how_to_liv_plot.ipynb

@@ -0,0 +1,419 @@
+{


Do we want to allow the user to specify a wider wavelength range than that covered by the model? Not sure -- let's discuss in our meeting...

Reply via ReviewNB

docs/io/visualization/how_to_liv_plot.ipynb

jamesgillanders · 2024-07-09T14:23:12Z

Hi Sarthak, great work so far!

I looked through the code and it looks good -- nice and concise, and clearly laid out.

I have added a bunch of comments to the notebook that came up when I was playing around with the tool. It would be good to get these additional modifications made to the tool -- I think they'll all improve it in some way. If any comments aren't clear, just send me a message and I can provide more detail. Or we can discuss in our meeting tomorrow.

jamesgillanders

See my comments above

jaladh-singhal

Thanks for addressing my previous comments as well as what we discussed in the last meeting. I only have few minor wording related suggestion - not a dealbreaker though. Good to merge!

tardis/visualization/tools/liv_plot.py

jaladh-singhal · 2024-07-12T15:01:16Z

tardis/visualization/tools/liv_plot.py

+        if self._species_list is None or not self._species_list:
+            raise ValueError("No species provided for plotting.")


I believe this is no longer the case since you updated the logic to handle None. But you know the edge cases better than me, so only remove it if you are sure

jamesgillanders

This looks great @sarthak-dv! Really happy with it, and happy to merge!

jamesgillanders requested review from jaladh-singhal, jamesgillanders and MarkMageeAstro June 26, 2024 14:39

jamesgillanders added the visualization label Jun 26, 2024

sarthak-dv force-pushed the line-interaction-radius branch from 7f55bcb to 5caa940 Compare June 27, 2024 11:11

sarthak-dv force-pushed the line-interaction-radius branch from e80fc33 to 3b9a07f Compare June 29, 2024 16:41

sarthak-dv marked this pull request as ready for review July 2, 2024 14:12

jaladh-singhal requested changes Jul 3, 2024

View reviewed changes

jaladh-singhal reviewed Jul 3, 2024

View reviewed changes

jaladh-singhal added the build-docs label Jul 3, 2024

sarthak-dv force-pushed the line-interaction-radius branch 2 times, most recently from cb8c2a7 to 3911ddf Compare July 8, 2024 23:13

jamesgillanders reviewed Jul 9, 2024

View reviewed changes

jamesgillanders requested changes Jul 9, 2024

View reviewed changes

sarthak-dv force-pushed the line-interaction-radius branch 2 times, most recently from 6f630a9 to 046f3b8 Compare July 11, 2024 17:41

sarthak-dv requested review from jamesgillanders and jaladh-singhal July 12, 2024 06:27

andrewfullard enabled auto-merge (squash) July 12, 2024 14:25

jaladh-singhal changed the title ~~Last Interaction Radius Plot~~ Last Interaction Velocity Plot Jul 12, 2024

jaladh-singhal previously approved these changes Jul 12, 2024

View reviewed changes

auto-merge was automatically disabled July 13, 2024 18:22
Head branch was pushed to by a user without write access

sarthak-dv dismissed jaladh-singhal’s stale review via 848575f July 13, 2024 18:22

sarthak-dv force-pushed the line-interaction-radius branch from a83d4a6 to dbc3b09 Compare July 13, 2024 20:43

sarthak-dv requested a review from jaladh-singhal July 15, 2024 13:46

andrewfullard enabled auto-merge (squash) July 15, 2024 13:52

sarthak-dv added 24 commits July 17, 2024 03:21

change model to plasma

68ee05a

graph plot

a3b8137

plotly graph

2b827f2

restore grotirian_mockup

0704314

add no_of_shells

2eeb8bb

Data Mapping Fix

9397c93

Code refactor

e35df20

Update Notebook

539aadb

Change colorbar labels

7ae11b8

Add log_scale, bins_range

67ff930

Add Comment

2da3a9a

Change velocity in from_hdf

b654d28

num_bins update

c5060b9

Name Changes,Code refactor

2acd1d3

Change species_list param

08f2846

create get_step_plot func

6b21c16

indentation change

fc722ce

Documentation

64f7b35

default species_list fix

b2c742b

test TODO fix

d0a7100

num_bins fix

cbd88b7

graph_height change

07c5cda

nelements fix

3a7de52

Refactor

06e4fe8

sarthak-dv force-pushed the line-interaction-radius branch from bdd1b4b to 06e4fe8 Compare July 16, 2024 21:53

jaladh-singhal approved these changes Jul 17, 2024

View reviewed changes

jamesgillanders approved these changes Jul 17, 2024

View reviewed changes

jamesgillanders merged commit 94fccbe into tardis-sn:master Jul 17, 2024
10 checks passed

sarthak-dv changed the title ~~Last Interaction Velocity Plot~~ Last Interaction Velocity Aug 12, 2024

sarthak-dv deleted the line-interaction-radius branch August 22, 2024 21:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Last Interaction Velocity #2677

Last Interaction Velocity #2677

sarthak-dv commented Jun 24, 2024 •

edited

Loading

review-notebook-app bot commented Jun 24, 2024

tardis-bot commented Jun 24, 2024 •

edited

Loading

sarthak-dv commented Jun 28, 2024 •

edited

Loading

jaladh-singhal left a comment

jamesgillanders Jul 9, 2024 •

edited

Loading

jamesgillanders commented Jul 9, 2024

jamesgillanders left a comment

jaladh-singhal left a comment

jaladh-singhal Jul 12, 2024

jamesgillanders left a comment

		if self._species_list is None or not self._species_list:
		raise ValueError("No species provided for plotting.")

Last Interaction Velocity #2677

Last Interaction Velocity #2677

Conversation

sarthak-dv commented Jun 24, 2024 • edited Loading

📝 Description

📌 Resources

🚦 Testing

☑️ Checklist

review-notebook-app bot commented Jun 24, 2024

tardis-bot commented Jun 24, 2024 • edited Loading

sarthak-dv commented Jun 28, 2024 • edited Loading

jaladh-singhal left a comment

Choose a reason for hiding this comment

jamesgillanders Jul 9, 2024 • edited Loading

Choose a reason for hiding this comment

jamesgillanders commented Jul 9, 2024

jamesgillanders left a comment

Choose a reason for hiding this comment

jaladh-singhal left a comment

Choose a reason for hiding this comment

jaladh-singhal Jul 12, 2024

Choose a reason for hiding this comment

jamesgillanders left a comment

Choose a reason for hiding this comment

sarthak-dv commented Jun 24, 2024 •

edited

Loading

tardis-bot commented Jun 24, 2024 •

edited

Loading

sarthak-dv commented Jun 28, 2024 •

edited

Loading

jamesgillanders Jul 9, 2024 •

edited

Loading