[Restructure/plasma] restructure the Radiationfields #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace.py, transport_montecarlo_numba_interface.py, conftest.py, formal_integral.py, base.py, and macro_atom.py
wkerzendorf
changed the title
wkerzendorf
changed the title
andrewfullard
requested changes
Jun 21, 2024
astropy_helpers
Outdated
docs/physics/nlte/nlte_rates.ipynb
Outdated
There was a problem hiding this comment.
These notebooks are good but not referenced in any contents file
andrewfullard
requested changes
Jul 23, 2024
Refactor the `parse_radiation_field_configuration.py` module to improve code organization and readability. Update the import statements to reflect the changes in the module structure. Replace the deprecated `DiluteBlackBodyRadiationFieldState` class with the new `DilutePlanckianRadiationField` class from the `tardis.plasma.radiation_field` module. This change ensures consistency and compatibility with the latest codebase. Also, update the `tardis/simulation/base.py` module to import the `DilutePlanckianRadiationField` class from the `tardis.plasma.radiation_field` module. This change ensures that the correct class is used for creating the radiation field in the simulation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2613 +/- ##
==========================================
- Coverage 36.58% 36.50% -0.08%
==========================================
Files 186 186
Lines 14859 14922 +63
==========================================
+ Hits 5436 5448 +12
- Misses 9423 9474 +51 ☔ View full report in Codecov by Sentry. |
Rodot-
previously approved these changes
Jul 24, 2024
andrewfullard
previously approved these changes
Jul 24, 2024
|
Just need to run black please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have to merge #2609