Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Liv Plot Data #23

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Sumit112192
Copy link
Contributor

📝 Description

Type: 🪲 bugfix
Need to change the data after changing the way line_interaction_in_r is updated. PR tardis-sn/tardis#2811.

@Sumit112192 Sumit112192 marked this pull request as draft August 27, 2024 18:26
@Sumit112192 Sumit112192 marked this pull request as ready for review August 29, 2024 11:04
@Sumit112192
Copy link
Contributor Author

@andrewfullard

@andrewfullard
Copy link
Contributor

Do you know what the difference is?

@Sumit112192
Copy link
Contributor Author

The velocity values will be changed since the r values have changed. Don't know the exact diff data. They were generated by the pytest.

@andrewfullard
Copy link
Contributor

Could you pick one file and diff it? We have docs on how to do that here https://tardis-sn.github.io/tardis/io/hdf/index.html

@Sumit112192
Copy link
Contributor Author

Could you pick one file and diff it? We have docs on how to do that here https://tardis-sn.github.io/tardis/io/hdf/index.html

Okay. I will do that and share the diff.

@Sumit112192
Copy link
Contributor Author

(tardis) sam@sam-Latitude-5480:~/TARDIS$ h5diff -v test_generate_plot_mpl__plotter_generate_plot_mpl0__.h5 tardis-regression-data/tardis/visualization/tools/tests/test_liv_plot/test_liv_plotter/test_generate_plot_mpl__plotter_generate_plot_mpl0__.h5 /plot_data_hdf/data0/block0_values

dataset: </plot_data_hdf/data0/block0_values> and </plot_data_hdf/data0/block0_values>
size:           [20x2]           [20x2]
position        block0_values   block0_values   difference          
------------------------------------------------------------
[ 0 1 ]          167             154             13             
[ 1 1 ]          167             154             13             
[ 2 1 ]          76              85              9              
[ 3 1 ]          76              85              9              
[ 4 1 ]          34              38              4              
[ 5 1 ]          34              38              4              
6 differences found
attribute: <CLASS of </plot_data_hdf/data0/block0_values>> and <CLASS of </plot_data_hdf/data0/block0_values>>
0 differences found
attribute: <FLAVOR of </plot_data_hdf/data0/block0_values>> and <FLAVOR of </plot_data_hdf/data0/block0_values>>
0 differences found
attribute: <TITLE of </plot_data_hdf/data0/block0_values>> and <TITLE of </plot_data_hdf/data0/block0_values>>
0 differences found
attribute: <VERSION of </plot_data_hdf/data0/block0_values>> and <VERSION of </plot_data_hdf/data0/block0_values>>
0 differences found
attribute: <transposed of </plot_data_hdf/data0/block0_values>> and <transposed of </plot_data_hdf/data0/block0_values>>
0 differences found

@Sumit112192
Copy link
Contributor Author

Is there a way to make it more human-readable? @andrewfullard

@andrewfullard andrewfullard merged commit e487ee7 into tardis-sn:main Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants