documentation on types of STARDIS returns (model, plasma, rad-field) #230
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,746 @@ | |||
| { | |||
There was a problem hiding this comment.
Careful about your imports. Not sure you use download_atom_data anywhere in this notebook.
Reply via ReviewNB
There was a problem hiding this comment.
Addressed in 'stellar_radiation and import fix'
| @@ -0,0 +1,746 @@ | |||
| { | |||
There was a problem hiding this comment.
Probably easier to just show the shape of one of these things, and say generically that they are of shape, (depth_point_index, wavelength_index)
Reply via ReviewNB
There was a problem hiding this comment.
Addressed in 'stellar_radiation and import fix'
| @@ -0,0 +1,746 @@ | |||
| { | |||
There was a problem hiding this comment.
We talked a bit about this, but it's probably better to just show a plot demonstrating what these things are than printing out the very large dictionary with very many numbers.
Reply via ReviewNB
There was a problem hiding this comment.
Addressed in 'stellar_radiation and import fix'
📝 Description
Type: 📝
documentationThis is the draft documentation for explaining the return options of STARDIS, describing and giving examples of Stellar_Model, Stellar_Plasma, and Stellar_Radiation_Field use cases.
Also, link issues affected by this pull request by using the keywords:
close,closes,closed,fix,fixes,fixed,resolve,resolvesorresolved.📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel