Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add microturbulence to simulation #222

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

jvshields
Copy link
Contributor

There's also an option in the config to disable microturbulence.

Here's a solar spectrum of H-Alpha with microturbulence read from the Marcs model
korg_micro

Here's that with microturbulence disabled.
korg_micro_disabled

Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, though your plot legend seems incorrect

@jvshields
Copy link
Contributor Author

Tests fail because of the full regression test which needs new data, but I don't quite know how to do that yet and it will be in a different PR.

@wkerzendorf wkerzendorf merged commit 45fa45b into tardis-sn:main Oct 18, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants