Add individual intensities #212
Open
+470
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… legendre polynomial
jvshields
force-pushed
the
add_individual_intensities
branch
from
704255f
to
e894d63
Compare
Closed
stardis/io/model/marcs.py
Outdated
| # Then add each of the matched patterns as a key:value pair to the metadata dict. | ||
| metadata_re = [re.compile(re_str[0]) for re_str in METADATA_RE_STR] | ||
| metadata = {} | ||
| METADATA_SPHERICAL_RE_STR = [ |
There was a problem hiding this comment.
This is so long it would probably be best in its own file and imported
|
The new and modified functions could really use tests |
|
Add a plot to this PR to show it's working |
|
I want to change this PR to make the simulation only keep track of each individual ray when you request the simulation to return the radiation field. As is, we end up using a ton of memory on all of the rays. Edit: Did this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on spherical geometry because the inspection of individual intensity rays is mainly used for testing the difference between plane parallel and spherical geometry. Spherical geometry should be merged first.