Running stardis test with tardis push commits #201
Conversation
|
Sample dispatch: |
|
https://github.com/KasukabeDefenceForce/stardis/actions/runs/10009941365/job/27669964721 I made some changes with ion_number_density, so that the stardis tests fail and it worked. |
KasukabeDefenceForce
requested review from
jvshields,
atharva-2001 and
andrewfullard
.github/workflows/tests.yml
Outdated
| @@ -65,8 +67,14 @@ jobs: | |||
| id: install-tardis | |||
| # shell: bash -l {0} | |||
| run: | | |||
| pip install git+https://github.com/tardis-sn/tardis.git | |||
|
|
|||
| if [ "${{ github.event.action }}" == "Tardis-Dispatch" ]; then | |||
There was a problem hiding this comment.
just do this using if conditional syntax of github actions right?
There was a problem hiding this comment.
We can do that as well, i thought creating two different steps might be confusing. But i will refactor this with if syntax of github actions.
.github/workflows/tests.yml
Outdated
| @@ -2,6 +2,8 @@ name: tests | |||
|
|
|||
| on: | |||
| push: | |||
| repository_dispatch: | |||
| types: [Tardis-Dispatch] | |||
There was a problem hiding this comment.
should be tardis-dispatch right? is the convention alright?
There was a problem hiding this comment.
yep i will fix this.
.github/workflows/tests.yml
Outdated
|
|
||
| if [ "${{ github.event.action }}" == "Tardis-Dispatch" ]; then | ||
| echo "Triggered by repository dispatch, installing the latest version of TARDIS." | ||
| pip install git+https://github.com/${{github.repository_owner}}/tardis.git@${{ github.event.client_payload.commit_sha }} |
There was a problem hiding this comment.
sorry if I dont understand this completely,the commit sha, is this intended to be sent by the pull request? will this work as a part of the release workflow? what about workflow dispatch?
There was a problem hiding this comment.
After giving more thought to this, i believe there is no need for the if else condtions, because it is already fetching the latest commit in both cases. The release workflow merges a PR into the master so that will trigger it and yes we can trigger it manually as well.
.github/workflows/tests.yml
Outdated
| pip install git+https://github.com/${{github.repository_owner}}/tardis.git@${{ github.event.client_payload.commit_sha }} | ||
| else | ||
| echo "Not triggered by repository dispatch, installing the latest version of TARDIS." | ||
| pip install git+https://github.com/${{ github.repository_owner }}/tardis.git |
There was a problem hiding this comment.
repo owner will always be tardis-sn right?
📝 Description
Type: 🪲
bugfix| 🚀feature| ☣️breaking change| 🚦testing| 📝documentation| 🎢infrastructureThe PR aims to run stardis tests after every commit on the tardis master branch. It is related to #2708 in tardis.
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel