Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle case of strings in config update #195

Merged
merged 3 commits into from
Jun 21, 2024
Merged

handle case of strings in config update #195

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41e0d22
handle case of strings
jvshields Jun 17, 2024
d700acf
remove duplicated code
jvshields Jun 17, 2024
9d8c1af
catch errors
jvshields Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions stardis/io/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,22 @@ def parse_config_to_model(config_fname, add_config_keys=None, add_config_vals=No
pass
else:
print("Updating config with additional keys and values")
try:
for key, val in zip(add_config_keys, add_config_vals):
config.set_config_item(key, val)
except:
if isinstance(add_config_keys, str):
# Directly set the config item if add_config_keys is a string
config.set_config_item(add_config_keys, add_config_vals)
else:
# Proceed with iteration if add_config_keys is not a string
if len(add_config_keys) != len(add_config_vals):
raise ValueError(
"Length of additional config keys and values do not match."
)
try:
for key, val in zip(add_config_keys, add_config_vals):
config.set_config_item(key, val)
except:
raise ValueError(
f"{add_config_keys} not a valid type. Should be a single string or a list of strings for keys."
)

try:
config_dict = validate_dict(config, schemapath=SCHEMA_PATH)
Expand Down
Loading