update installation instructions and small changes in physics_of_stardis #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
docs/physics/physics_of_stardis.rst
Outdated
| @@ -6,7 +6,7 @@ Physics of STARDIS | |||
| Model and Plasma | |||
| ================ | |||
|
|
|||
| STARDIS breaks down the stellar atmosphere into spherical shells as shown below and approximates that the plasma state is uniform throughout each shell. We rely on the MARCS code, a code that generates models of stellar atmospheres, to determine the temperatures, elemental abundances, and densities in each shell. The existing TARDIS plasma infrastructure determines the rest of the plasma state, namely the excitation and ionization properties and transition rates. | |||
| STARDIS breaks down the stellar atmosphere into spherically symmetric depth points as shown below and approximates that the plasma state is uniform at each radius or depth point. We ingest a model atmosphere from a third party such as the MARCS code, a code that generates models of stellar atmospheres, to initialize the temperatures, chemical abundances, and densities at each depth point. The existing TARDIS plasma infrastructure determines the rest of the plasma state, namely the excitation and ionization properties and transition rates of the plasma. | |||
There was a problem hiding this comment.
Please add a sentence or two about depth points.
DeerWhale
approved these changes
Jun 17, 2024
DeerWhale
approved these changes
Jun 17, 2024
Knights-Templars
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation instructions didn't actually work because they ask you to make an environment from a lock file, but they don't tell you how to get that lock file. They also mentioned a pinned TARDIS version, which we moved away from. This fixes those issues.