Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose model params #185

Merged
merged 7 commits into from
Apr 15, 2024
Merged

Conversation

jvshields
Copy link
Contributor

This PR restructures the high level run_stardis() function to only be a helper function that calls a couple other functions scattered throughout the code. This makes it much easier to effectively run the function on your own so you can parse a model, edit the model as a python object, and then run the rest of the function.

This is intended to make it easier to modify specific abundances and investigate their impacts on lines in the spectrum.

Still need to make an easy helper function that takes in the stellar model, and allows you to request an abundance of some given element, and then rescale the rest of the elements appropriately.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 68.20%. Comparing base (feeb2db) to head (0f6901b).

❗ Current head 0f6901b differs from pull request most recent head 60fdbc9. Consider uploading reports for the commit 60fdbc9 to get more accurate results

Files Patch % Lines
stardis/io/base.py 67.74% 10 Missing ⚠️
stardis/base.py 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   67.91%   68.20%   +0.29%     
==========================================
  Files          31       32       +1     
  Lines        1203     1214      +11     
==========================================
+ Hits          817      828      +11     
  Misses        386      386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wkerzendorf wkerzendorf self-requested a review April 15, 2024 14:52
@jvshields jvshields merged commit 99bc5dc into tardis-sn:main Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants