Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marcs model ingestion bugfix #147

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

jvshields
Copy link
Contributor

@jvshields jvshields commented Nov 30, 2023

This is a small bugfix change. I had implemented a less-than-ideal way of ingesting marcs models and calculating atomic mass fractions that set atomic numbers greater than the final atomic number to nan. These get truncated again later on, so there's no real reason to do this and it just makes pandas spit out a bunch of warnings for (understandably) bad code.

There's also two sourcery facelifts that just make the code a little easier to read.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b560322) 66.73% compared to head (62a209f) 66.66%.

Files Patch % Lines
stardis/io/model/marcs.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   66.73%   66.66%   -0.07%     
==========================================
  Files          27       27              
  Lines        1016     1011       -5     
==========================================
- Hits          678      674       -4     
+ Misses        338      337       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvshields jvshields merged commit d193493 into tardis-sn:main Dec 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants