Cleanup and rename cell length #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jing Lu <[email protected]> Co-authored-by: Yuki Matsumura <[email protected]> Co-authored-by: 饒孝節 <[email protected]>
Co-authored-by: Jing Lu <[email protected]> Co-authored-by: Yuki Matsumura <[email protected]> Co-authored-by: 饒孝節 <[email protected]>
Co-authored-by: Yuki Matsumura <[email protected]> Co-authored-by: 饒孝節 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 34.99% 34.99%
=======================================
Files 16 16
Lines 623 623
=======================================
Hits 218 218
Misses 405 405
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sonachitchyan
approved these changes
Jul 26, 2023
isaacgsmith
approved these changes
Jul 26, 2023
smokestacklightnin
pushed a commit
to smokestacklightnin/stardis
that referenced
this pull request
Jul 27, 2023
* add functionality to read not gzipped files to marcs reader * remove WIP for geometry that would break the reader Co-authored-by: Jing Lu <[email protected]> Co-authored-by: Yuki Matsumura <[email protected]> Co-authored-by: 饒孝節 <[email protected]> * Co-authored-by: Jing Lu <[email protected]> Co-authored-by: Yuki Matsumura <[email protected]> Co-authored-by: 饒孝節 <[email protected]> * Change documentation and names of "cells" * change radial1d.py mentions of cell to depth point --------- Co-authored-by: Jing Lu <[email protected]> Co-authored-by: Yuki Matsumura <[email protected]> Co-authored-by: 饒孝節 <[email protected]> Co-authored-by: Sona Chitchyan <[email protected]>
smokestacklightnin
pushed a commit
to smokestacklightnin/stardis
that referenced
this pull request
Sep 20, 2023
* add functionality to read not gzipped files to marcs reader * remove WIP for geometry that would break the reader Co-authored-by: Jing Lu <[email protected]> Co-authored-by: Yuki Matsumura <[email protected]> Co-authored-by: 饒孝節 <[email protected]> * Co-authored-by: Jing Lu <[email protected]> Co-authored-by: Yuki Matsumura <[email protected]> Co-authored-by: 饒孝節 <[email protected]> * Change documentation and names of "cells" * change radial1d.py mentions of cell to depth point --------- Co-authored-by: Jing Lu <[email protected]> Co-authored-by: Yuki Matsumura <[email protected]> Co-authored-by: 饒孝節 <[email protected]> Co-authored-by: Sona Chitchyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing mentions of cell lengths in variables and documentation to start moving towards finite difference model implementation rather than finite volume.