Add scalar division for vectors #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunsided
force-pushed
the
feature/vector-div
branch
from
c40f7a3
to
071eb89
Compare
tarcieri
approved these changes
Jul 25, 2024
|
@sunsided needs a rebase |
sunsided
force-pushed
the
feature/vector-div
branch
4 times, most recently
from
a6fc44d
to
248fd7b
Compare
|
@sunsided needs another rebase, hopefully the last one! |
sunsided
force-pushed
the
feature/vector-div
branch
from
248fd7b
to
a809e16
Compare
|
@tarcieri Sure thing! |
tarcieri
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #105 that adds scalar division to vectors. Only the standard division (
Div<C> for VectorXd<C>) is implemented, not the left-handed version of it.