This repository was archived by the owner on Jan 1, 2024. It is now read-only.
Add twophase_validate_config_timeout variable __
#426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, when we're working with highloaded cluster, which can't apply CW-config with default timeouts, we have to increase all twophase-timeouts. Before the patch, there were only three of four `cartridge.twophase` timeouts: - `twophase_netbox_call_timeoyt` -> `netbox_call_timeout`; - `twophase_upload_config_timeoyt` -> `updload_config_timeout`; - `twophase_apply_config_timeout` -> `apply_config_timeout`; So, we didn't have an ability to set the `validate_config_timeout` variable. Closes tarantool#425
|
Seems that most of checks fall because of troubles with environment. Do we need fix it before merge? |
hackallcode
approved these changes
Jul 19, 2023
opomuc
changed the title
twophase_validate_config_timeout variabletwophase_validate_config_timeout variable __
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, when we work with highloaded cluster, which can't apply CW-config with default timeouts,
we have to increase all twophase-timeouts.
Before the patch, there were only three of four
cartridge.twophasetimeouts:twophase_netbox_call_timeout->netbox_call_timeout;twophase_upload_config_timeout->updload_config_timeout;twophase_apply_config_timeout->apply_config_timeout;So, we didn't have an ability to set the
validate_config_timeoutvariable.Closes #425