-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
マスターへmerge #32
base: master
Are you sure you want to change the base?
マスターへmerge #32
Conversation
.idea/ディレクトリを無視
Feature/#1add bottom navigation
…-registration Feature/#8create user information registration
検索窓とカテゴリのvisibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良くできてます!
app/build.gradle
Outdated
jvmTarget = '1.8' | ||
} | ||
dataBinding { | ||
enabled = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dataBindingが2つある 🙄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
class EventListDetailFragment : Fragment() { | ||
|
||
private var event: Event? = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by lazyを使うと良いかも(書き方が違うかもしれないのでby lazyの使い方調べてみてください)
private var event: Event? by lazy {
argument.getSerializable(CONNPASS_EVENTS) as? Event
}
|
||
class SearchActivity : AppCompatActivity() { | ||
|
||
var searchKey: String? = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
privaste
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
override fun onQueryTextSubmit(query: String?): Boolean { | ||
searchKey = query.toString() | ||
val bundle = Bundle() | ||
bundle.putString("searchKey", searchKey) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
searchKey
を定数にする
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
override fun onCreate(savedInstanceState: Bundle?) { | ||
super.onCreate(savedInstanceState) | ||
|
||
val appCompatActivity = activity as AppCompatActivity? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requireActivity()
を使う
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title = event!!.title, | ||
date = event!!.startedAt, | ||
location = event!!.address ?: "不明", | ||
url = event!!.eventURL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
強制アンラップは禁止
event?.let {
SavedEvent(title = it.title)
}
val prefs = context?.getSharedPreferences(UserInformationViewModel.PREF, Context.MODE_PRIVATE) | ||
val favWord1 = prefs?.getString(UserInformationViewModel.KEY_FAV_WORD1, "Kotlin") | ||
|
||
EventListRepository.listArticle(PER_PAGE, favWord1).observe(viewLifecycleOwner, androidx.lifecycle.Observer { events: ArrayList<Event> -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EventListRepository.listArticle()を2回呼んでるので引数だけ変わるような実装にしたい
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import com.example.intern_3days_hackathon.R | ||
|
||
private const val ARG_PARAM1 = "key" | ||
private const val ARG_PARAM2 = "value" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
できればここには書きたくない
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class UserEditDialogFragment : DialogFragment() { | ||
|
||
private var KEY: String? = "key" | ||
private var VALUE: String? = "value" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
キャメルケースで書く。プロジェクトで揃える
android:id="@+id/search_layout_frame" | ||
<SearchView | ||
android:id="@+id/searchView" | ||
android:layout_width="match_parent" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConstraintLayoutの中ではmatch_parentは使いたくない
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
databindingを使用可能な部分に適用
…ar-icon BottomNavigationBarのアイコンを実装
…op-to-master Feature/35 fix review merge develop to master
アプリ概要
connpassのイベントを検索するアプリです。
お気に入りのイベントを保存することができます。
機能・こだわり
イベント検索
検索窓からイベントの検索ができます。
お気に入りワードをデフォルトで検索
アプリ起動直後は端末に保存したお気に入りワードで検索されたイベントが表示されるようにしています。
検索結果のリスト表示
お気に入りイベント保存・削除
保存したイベントのリスト表示
ユーザー情報登録画面
お気に入りワード登録