マスターへmerge #32
Open
マスターへmerge #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.idea/ディレクトリを無視
Feature/#1add bottom navigation
…-registration Feature/#8create user information registration
検索窓とカテゴリのvisibility
|
hyoshimi-cq
reviewed
Aug 28, 2020
app/build.gradle
Outdated
| jvmTarget = '1.8' | ||
| } | ||
| dataBinding { | ||
| enabled = true |
|
|
||
| class EventListDetailFragment : Fragment() { | ||
|
|
||
| private var event: Event? = null |
There was a problem hiding this comment.
by lazyを使うと良いかも（書き方が違うかもしれないのでby lazyの使い方調べてみてください）
private var event: Event? by lazy {
argument.getSerializable(CONNPASS_EVENTS) as? Event
}|
|
||
| class SearchActivity : AppCompatActivity() { | ||
|
|
||
| var searchKey: String? = null |
| override fun onQueryTextSubmit(query: String?): Boolean { | ||
| searchKey = query.toString() | ||
| val bundle = Bundle() | ||
| bundle.putString("searchKey", searchKey) |
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
|
|
||
| val appCompatActivity = activity as AppCompatActivity? |
| title = event!!.title, | ||
| date = event!!.startedAt, | ||
| location = event!!.address ?: "不明", | ||
| url = event!!.eventURL, |
There was a problem hiding this comment.
強制アンラップは禁止
event?.let {
SavedEvent(title = it.title)
}| val prefs = context?.getSharedPreferences(UserInformationViewModel.PREF, Context.MODE_PRIVATE) | ||
| val favWord1 = prefs?.getString(UserInformationViewModel.KEY_FAV_WORD1, "Kotlin") | ||
|
|
||
| EventListRepository.listArticle(PER_PAGE, favWord1).observe(viewLifecycleOwner, androidx.lifecycle.Observer { events: ArrayList<Event> -> |
There was a problem hiding this comment.
EventListRepository.listArticle()を2回呼んでるので引数だけ変わるような実装にしたい
| import com.example.intern_3days_hackathon.R | ||
|
|
||
| private const val ARG_PARAM1 = "key" | ||
| private const val ARG_PARAM2 = "value" |
| class UserEditDialogFragment : DialogFragment() { | ||
|
|
||
| private var KEY: String? = "key" | ||
| private var VALUE: String? = "value" |
| android:id="@+id/search_layout_frame" | ||
| <SearchView | ||
| android:id="@+id/searchView" | ||
| android:layout_width="match_parent" |
There was a problem hiding this comment.
ConstraintLayoutの中ではmatch_parentは使いたくない
Merged
databindingを使用可能な部分に適用
…ar-icon BottomNavigationBarのアイコンを実装
…op-to-master Feature/35 fix review merge develop to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
アプリ概要
connpassのイベントを検索するアプリです。
お気に入りのイベントを保存することができます。
機能・こだわり
イベント検索
検索窓からイベントの検索ができます。
お気に入りワードをデフォルトで検索
アプリ起動直後は端末に保存したお気に入りワードで検索されたイベントが表示されるようにしています。
検索結果のリスト表示
お気に入りイベント保存・削除
保存したイベントのリスト表示
ユーザー情報登録画面
お気に入りワード登録