Skip to content

Commit

Permalink
fix(core): preventDefault() error
Browse files Browse the repository at this point in the history
  • Loading branch information
taobataoma committed Jun 30, 2017
1 parent fee91f8 commit e6aeab3
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 16 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ Methods:
tip: param `id` is the popup element id, if given `event` param, will auto run codes follow for you:
```javascript
event.stopPropagation();
event.preventDefault();
```

#### Directive: "side-overlay"
Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular-side-overlay",
"version": "1.0.2",
"version": "1.0.3",
"homepage": "https://github.com/taobataoma/angular-side-overlay",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion dist/angular-side-overlay.css
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* angular-side-overlay - angular side overlay component
* @author taobataoma
* @version v1.0.0
* @version v1.0.3
* @link https://github.com/taobataoma/angular-side-overlay#readme
* @license MIT
*/
Expand Down
7 changes: 2 additions & 5 deletions dist/angular-side-overlay.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
/**
* angular-side-overlay - angular side overlay component
* @author taobataoma
* @version v1.0.0
* @version v1.0.3
* @link https://github.com/taobataoma/angular-side-overlay#readme
* @license MIT
*/
angular.module('ngSideOverlay', []);
angular.module('ngSideOverlay').constant('MODULE_VERSION', '1.0.1');
angular.module('ngSideOverlay').constant('MODULE_VERSION', '1.0.3');
angular.module('ngSideOverlay').value('sideCallbackEvent', [
{
id: undefined,
Expand Down Expand Up @@ -37,7 +37,6 @@ angular.module('ngSideOverlay').provider('SideOverlay', function () {

if (evt && typeof evt.altKey !== "undefined") {
evt.stopPropagation();
evt.preventDefault();
}
};

Expand All @@ -55,7 +54,6 @@ angular.module('ngSideOverlay').provider('SideOverlay', function () {

if (evt && typeof evt.altKey !== "undefined") {
evt.stopPropagation();
evt.preventDefault();
}
};

Expand Down Expand Up @@ -190,7 +188,6 @@ function sideOverlay(sideCallbackEvent) {
//sideOpened & sideClosed event
element.bind('click', function (evt) {
evt.stopPropagation();
evt.preventDefault();
});

//sideOpened & sideClosed event
Expand Down
2 changes: 1 addition & 1 deletion dist/angular-side-overlay.min.css
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* angular-side-overlay - angular side overlay component
* @author taobataoma
* @version v1.0.0
* @version v1.0.3
* @link https://github.com/taobataoma/angular-side-overlay#readme
* @license MIT
*/
Expand Down
4 changes: 2 additions & 2 deletions dist/angular-side-overlay.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular-side-overlay",
"version": "1.0.2",
"version": "1.0.3",
"description": "angular side overlay component",
"scripts": {
"test": "npm test",
Expand Down
5 changes: 1 addition & 4 deletions src/angular-side-overlay.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
angular.module('ngSideOverlay', []);
angular.module('ngSideOverlay').constant('MODULE_VERSION', '1.0.2');
angular.module('ngSideOverlay').constant('MODULE_VERSION', '1.0.3');
angular.module('ngSideOverlay').value('sideCallbackEvent', [
{
id: undefined,
Expand Down Expand Up @@ -30,7 +30,6 @@ angular.module('ngSideOverlay').provider('SideOverlay', function () {

if (evt && typeof evt.altKey !== "undefined") {
evt.stopPropagation();
evt.preventDefault();
}
};

Expand All @@ -48,7 +47,6 @@ angular.module('ngSideOverlay').provider('SideOverlay', function () {

if (evt && typeof evt.altKey !== "undefined") {
evt.stopPropagation();
evt.preventDefault();
}
};

Expand Down Expand Up @@ -183,7 +181,6 @@ function sideOverlay(sideCallbackEvent) {
//sideOpened & sideClosed event
element.bind('click', function (evt) {
evt.stopPropagation();
evt.preventDefault();
});

//sideOpened & sideClosed event
Expand Down

0 comments on commit e6aeab3

Please sign in to comment.